ISSUE-27954: Forgot password save user only one column

[sheepfy]

Fixes #27954

[m2-assistant]

Hi @sheepfy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[aleron75]

Hello @sheepfy thanks for your contribution, it's very appreciated.

Due to Magento Definition of Done, all code must be covered by tests.

For this specific case, this fix should be covered by automated tests with the scenario which leads to an issue.
Tests should fail on the mainline and pass with this fix.

To answer the question "which kind of tests should we write", I would go with a lightweight unit test.

[ihor-sviziev]

Hi @sheepfy,
Could you update your solution as it was requested here? #27972 (comment)

[sheepfy]

Hi @sheepfy,
Could you update your solution as it was requested here? #27972 (comment)

Hi, so, to be clear for me, you want me to implement unit tests for "ProductResource:: updateColumn" function ?
If that so, i can do it untill the end of this week

[ihor-sviziev]

@sheepfy I think yes + fix failing unit tests should be enough.

[engcom-Charlie]

Hi, @sheepfy could you please fix static and unit tests?
Thank you.

[sheepfy]

Hi, i’ll do my best do finish the test untill the end of the week, if not , i’ll let you know

…

On 24 Sep 2020, at 12:56, Vadim Malesh ***@***.***> wrote:  Hi, @sheepfy could you please fix static and unit tests? Thank you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[engcom-Charlie]

Hi, @sheepfy do you have any updates?
Thank you.

[engcom-Charlie]

Hi, @sheepfy please fix static and unit tests. Otherwise, we can't proceed with your PR.
Thank you.

[engcom-Charlie]

Hi, @sheepfy I'll continue with your PR.

[engcom-Charlie]

@ihor-sviziev totally agree with you.
As for me, the second suggestion about the flag would be better.
@sheepfy what do you think?

[engcom-Charlie]

@sheepfy I'll continue with your PR.

[engcom-Charlie]

@magento run all tests

[ihor-sviziev]

@engcom-Charlie thank you! now looks much better! Let's wait for test results

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8388 has been created to process this Pull Request

[magento-engcom-team]

@sheepfy thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sheepfy]

Hello, thanks for inviting me into the Community Contributors team. And sorry for the late reply and not continuing with the PR. Since first time a created and till now, things changed and i didn't have time to go on.

…

On Mon, 26 Oct 2020 at 12:26, Magento Community Engineering < ***@***.***> wrote: @sheepfy <https://github.com/sheepfy> thank you for contributing. Please accept Community Contributors team invitation here <https://github.com/orgs/magento/invitation> to gain extended permissions for this repository. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27972 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEFIULNANL2CH7J66DLJBM3SMVFFXANCNFSM4MQDKD6Q> .

[engcom-Bravo]

This PR fixes an issue for Magento Enterprise Edition

✔️ QA Passed

Manual testing scenario:

1. Go to Store->Configuration->Customer->Customer Configuration
2. Enable 'Require Emails Confirmation'
3. On Admin go to Customers->All customers and Add New Customer with address
4. Add some kind of validation to address fields in the Database (limit length for city name)
   UPDATE customer_eav_attribute SET validate_rules='{"input_validation":1,"min_text_length":0,"max_text_length":2}' WHERE attribute_id=(SELECT attribute_id FROM eav_attribute WHERE entity_type_id=2 AND attribute_code='city');
5. Go to frontend
6. Click Sign In
7. Click Forgot Your Password?
8. Fill fields and click Reset My Password
9. Open the email and click Set a New Password

Before applying changes provided in this PR, the Customer has been redirected to Forgot Your Password

After switching to the PR, the Customer is redirected to Set a New Password

[m2-assistant]

Hi @sheepfy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.