fixed negative children_count after deleting categories

[ProkopovVitaliy]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. children_count can become negative after deleting categories #27969: children_count can become negative after deleting categories

Manual testing scenarios (*)

1.Log in into admin backend
2.Navigate to Catalog -> Categories
3.Click "Add Subcategory"
4.Fill category name with "Parent 1", Save
5.Click "Add Subcategory"
6.Fill category name with "Child 1", Save
7.Click "Add Subcategory"
8.Fill category name with "Child 2", Save
9.Click "Add Subcategory"
10.Fill category name with "Child 3", Save. At this point this category should have level = 5
11.Click on "Child 1" category
12.Delete category

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Echo]

I will take care of test coverage.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7513 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1.Log in into admin backend
2.Navigate to Catalog -> Categories
3.Click "Add Subcategory"
4.Fill category name with "Parent 1", Save
5.Click "Add Subcategory"
6.Fill category name with "Child 1", Save
7.Click "Add Subcategory"
8.Fill category name with "Child 2", Save
9.Click "Add Subcategory"
10.Fill category name with "Child 3", Save. At this point this category should have level = 5
11.Click on "Child 1" category
12.Delete category
13. See catalog_category_entity table

Before: ✖️ children_count for remaining categories have negative meanings

After: ✔️ children_count for remaining categories are valid

Also tested with few roots categories and Childs.

[ProkopovVitaliy]

@magento run Static Tests

[ProkopovVitaliy]

@magento run Unit Tests

[ProkopovVitaliy]

@magento run all tests

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-7513 has been created to process this Pull Request

[engcom-Delta]

Notice: QA not applicable
New commits are connected to tests

[m2-assistant]

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.