RequireJS resolver sometimes fails to detect blocked resources

[ishakhsuvarov]

Description (*)

Under certain circumstances Magento's RequireJS resolver would not correctly detect that all resources on the page were loaded or handled appropriately and cause "infinite loader" conditions. This can possibly be reproduced on Checkout

Also, it's sometimes possible to reproduce this condition by having magento/module-data-services module installed and using uBlock origin adblocker.

Related Pull Requests

N/A

Fixed Issues (if relevant)

Fixes #28116

Manual testing scenarios (*)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ishakhsuvarov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[slavvka]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[ihor-sviziev]

Hi @ishakhsuvarov,
Your changes looks good to me. Could you fix static tests and cover your change with js unit test?

[VladimirZaets]

@magento run all tests

[ihor-sviziev]

@ishakhsuvarov will you be able to update your PR?

[ihor-sviziev]

@engcom-Charlie @engcom-Kilo @engcom-Golf could you help with test coverage? it seems to me as really important fix

Thank you!

[ihor-sviziev]

@engcom-Kilo any updates on it?

[ihor-sviziev]

@magento run all tests.

I believe with JS unit test it will be not really easy to cover such case, so maybe it's better to keep it not covered, but have the fix, than not having such important fix at all.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7914 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

A manual scenario was used to test the issue #28116

Before:

✔️ Ad Blocker Extension blocks script download from the original url

✖️ Checkout page is displaying 2 spinning loaders and a fully rendered page under it as resolver does not track components which were loaded via fallbacks.

After:

✔️ Ad Blocker extension blocks the script download from the url stated in RequireJS config (https://example.com/advertisement.js)

✔️ Checkout page loads and renders just fine

[m2-assistant]

Hi @ishakhsuvarov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.