-
Notifications
You must be signed in to change notification settings - Fork 9.4k
RequireJS resolver sometimes fails to detect blocked resources #28117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequireJS resolver sometimes fails to detect blocked resources #28117
Conversation
Hi @ishakhsuvarov. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ishakhsuvarov,
Your changes looks good to me. Could you fix static tests and cover your change with js unit test?
@magento run all tests |
@ishakhsuvarov will you be able to update your PR? |
@engcom-Charlie @engcom-Kilo @engcom-Golf could you help with test coverage? it seems to me as really important fix Thank you! |
@engcom-Kilo any updates on it? |
Fix static tests
@magento run all tests. I believe with JS unit test it will be not really easy to cover such case, so maybe it's better to keep it not covered, but have the fix, than not having such important fix at all. |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed A manual scenario was used to test the issue #28116 Before: ✔️ Ad Blocker Extension blocks script download from the original url ✖️ Checkout page is displaying 2 spinning loaders and a fully rendered page under it as resolver does not track components which were loaded via fallbacks. After: ✔️ Ad Blocker extension blocks the script download from the url stated in RequireJS config ( ✔️ Checkout page loads and renders just fine |
Hi @ishakhsuvarov, thank you for your contribution! |
Description (*)
Under certain circumstances Magento's RequireJS resolver would not correctly detect that all resources on the page were loaded or handled appropriately and cause "infinite loader" conditions. This can possibly be reproduced on Checkout
Also, it's sometimes possible to reproduce this condition by having
magento/module-data-services
module installed and usinguBlock origin
adblocker.Related Pull Requests
N/A
Fixed Issues (if relevant)
Fixes #28116
Manual testing scenarios (*)
Contribution checklist (*)