Skip to content

Removed unused class imports #28696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2020
Merged

Removed unused class imports #28696

merged 2 commits into from
Jul 9, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jun 11, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This PR removes redundand class imports for some classes

Resolved issues:

  1. resolves [Issue] Removed unused class imports  #29012: Removed unused class imports

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 11, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@ghost ghost assigned aleron75 Jun 12, 2020
@aleron75
Copy link
Contributor

There are some failing tests related to B2B but I don't see any relation with this PR so I approved it.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-7673 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jul 2, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked cases create customer on frontend and in admin panel, refactored patches are applied without errors during magento install and setup:upgrade
#28696PR

@engcom-Echo engcom-Echo self-assigned this Jul 2, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 6, 2020
@slavvka slavvka added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 6, 2020
@slavvka
Copy link
Member

slavvka commented Jul 6, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 6, 2020
Closed
@slavvka slavvka added this to the 2.4.1 milestone Jul 6, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 9, 2020
@slavvka
ENGCOM-7673: Removed unused class imports #28696
6904e8c
@magento-engcom-team magento-engcom-team merged commit 04ce55a into magento:2.4-develop Jul 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 9, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

Assignees

@aleron75 aleron75

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Cleanup Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Removed unused class imports
6 participants
@Usik2203 @aleron75 @magento-engcom-team @engcom-Delta @engcom-Echo @slavvka