Fix shipping address id getter misspelling

[kodubovik]

Description (*)

Fixed a shipping address id getter misspelling in the sales order address save handler. Misspelt getter caused unneeded requests to the database on each order save which might create deadlocks.

Manual testing scenarios (*)

This bug can not be validated manually as there're no effects visible on the front-end.
The fix includes Unit tests to validate that address save handler does not execute save attribute method when it's not needed.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix shipping address id getter misspelling #28982: Fix shipping address id getter misspelling

[m2-assistant]

Hi @kodubovik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[kodubovik]

@magento run all tests

[ihor-sviziev]

@kodubovik good catch! This issue was there for 6 years!
I think it could be checked with adding breakpoint with xdebug.

Could you remove phpdoc block for Address class, as static tests complaining about it?

[ihor-sviziev]

Could you remove phpdoc block for Address class, as static tests complaining about it?

[kodubovik]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7723 has been created to process this Pull Request

[magento-engcom-team]

@kodubovik thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Delta]

✔️ QA passed
Was checked cases with place order as guest, place order as registered customer with same/different billing and shipping address, checkout with multiple addresses.

[engcom-Delta]

@magento create issue

[m2-assistant]

Hi @kodubovik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.