#28802: Fix typo retires => retries

[medigeek]

#28802: Fix typo retires => retries

Description (*)

#28802: Fix typo retires => retries

It would fix a typo of bin/magento command line setup:config:set argument/option

$ php bin/magento --help setup:config:set | grep retires
      --session-save-redis-sentinel-connect-retires=SESSION-SAVE-REDIS-SENTINEL-CONNECT-RETIRES  Redis Sentinel connect retries.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes typo: setup:config:set --session-save-redis-sentinel-connect-retires (instead of retries) #28802

Manual testing scenarios (*)

Questions or comments

1. checked for other "retires" occurences. not found.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @medigeek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[medigeek]

@magento run all tests

[lbajsarowicz]

Thank you for your contribution!

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7716 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@medigeek thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Delta]

✔️ QA passed
Before:

• ❌ Match with incorrect word retires

After:

• ✔️ No match with incorrect word retires
  

• ✔️ Match with correct word retries
  

[sdzhepa]

It looks like BIC changes. Moved to "To Approve" column for review

Pull Request state was updated. Re-review required.

[ihor-sviziev]

Seems like bot moved this PR to wrong status. moved back.

[sidolov]

@sdzhepa , @ihor-sviziev changing of const value is backward compatible according to our policy:

Changing the value of a constant
Changing the value of a constant is itself a backward compatible change.

Even if client code saves the value in permanent storage or use it as input or output of a method, it is the responsibility of that code to ensure that it is a reliable implementation.

The client code should have enough control over the constant’s value. Do not rely on a value of a constant from another module or another vendor.

[ihor-sviziev]

Fixed wrong status again

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7716 has been created to process this Pull Request

[m2-assistant]

Hi @medigeek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.