Skip to content

Improvement sticky navbar #28840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Improvement sticky navbar #28840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3c119a
Add sticky lib and implement for theme luma navigation
mrtuvn Jan 21, 2021
a9aca66
Merge branch '2.4-develop' into improvement-navbar-with-sticky
Oct 25, 2021
bd34002
Merge remote-tracking branch 'magento2/2.4-develop' into improvement-…
engcom-Charlie Nov 4, 2021
c935a30
Merge remote-tracking branch 'magento2/2.4-develop' into improvement-…
engcom-Charlie Jan 11, 2022
b224bdd
Merge remote-tracking branch 'magento2/2.4-develop' into improvement-…
engcom-Charlie Feb 17, 2022
91651e1
Merge remote-tracking branch 'magento2/2.4-develop' into improvement-…
engcom-Charlie Feb 17, 2022
46741e7
Merge remote-tracking branch 'magento2/2.4-develop' into improvement-…
engcom-Charlie Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
@message-global-caution-link__color-active: @link__active__color;
@message-global-caution__border-color: none;

@header__background-color: false;
@header-panel__background-color: @color-gray-middle4;
@header-panel__text-color: @color-white;
@header-icons-color: @color-gray46;
Expand Down Expand Up @@ -331,6 +330,7 @@
}
}
}

.page-header .panel.wrapper {
.switcher {
.options {
Expand Down Expand Up @@ -404,6 +404,10 @@
// _____________________________________________

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__m) {
.page-header {
.lib-sticky();
}

.customer-name,
.customer-welcome + .authorization-link {
display: none;
Expand Down Expand Up @@ -501,6 +505,10 @@
height: 100%; // Stretch screen area for sticky footer
}

.nav-sections {
.lib-sticky();
}

.navigation ul {
padding: 0 8px;
}
Expand Down
1 change: 1 addition & 0 deletions app/design/frontend/Magento/luma/web/css/source/_variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

// Colors nesting
@page__background-color: @color-white;
@header__background-color: @page__background-color;

//
// Icons
Expand Down
10 changes: 10 additions & 0 deletions lib/web/css/source/lib/_utilities.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@
@fontValue: @_value;
}

.lib-sticky(
@_z-index: @z-index-1 - 1,
@_top: 0
) {
position: -webkit-sticky;
position: sticky;
top: @_top;
z-index: @_z-index;
}

.lib-visibility-hidden() {
height: 0;
visibility: hidden;
Expand Down