Deploy all used locales #28922

AntonEvers · 2020-06-29T16:43:40Z

Description (*)

bin/magento setup:static-content:deploy --language=all currently only
deploys en_US, instead of the requested "all". This pull request aims to deploy all used languages for the frontend and all configured languages by admin users, when no language parameter is given. en_US is always additionally deployed by default.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Configure multiple store views with different locales.
Configure a locale other than en_US for your admin user.
run bin/magento setup:static-content:deploy --language=all and verify that all configured languages, plus en_US are deployed.
run bin/magento setup:static-content:deploy --language=all --exclude-language=en_US and verify that en_US is skipped.
run bin/magento setup:static-content:deploy en_US and verify that only en_US is deployed
run bin/magento setup:static-content:deploy --language=en_US and verify that only en_US is deployed
run bin/magento setup:static-content:deploy -l en_US and verify that only en_US is deployed
run bin/magento setup:static-content:deploy --language=en_US en_UK and verify that only en_UK is deployed as the languages argument precedes over the language option

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Deploy all used locales #29218: Deploy all used locales

m2-assistant · 2020-06-29T16:43:43Z

Hi @AntonEvers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

AntonEvers · 2020-06-29T16:52:21Z

@magento run all tests

AntonEvers · 2020-06-30T11:04:42Z

@magento run Unit Tests

AntonEvers · 2020-06-30T14:32:02Z

@magento run all tests

VladimirZaets · 2020-07-09T22:22:50Z

Hi @AntonEvers. Thanks for collaboration. This PR was reviewed on Community Contribution Triage meeting. The recording of the meeting you can look by the link

ihor-sviziev

@AntonEvers thank you so much for your contribution!
This is really important improvement!

app/code/Magento/Deploy/Package/PackagePool.php

AntonEvers · 2020-07-14T13:52:01Z

@ihor-sviziev please let me know if this needs some cleaning up / relocation of logic. I can imagine that the coupling of objects is getting larger than desirable at the moment.

AntonEvers · 2020-07-14T13:52:53Z

@magento run all tests

AntonEvers · 2020-07-14T15:30:48Z

@ihor-sviziev please let me know if this needs some cleaning up / relocation of logic. I can imagine that the coupling of objects is getting larger than desirable at the moment.

I went ahead and cleaned up a little. Please let me know if you see any issues with this.

AntonEvers · 2020-07-14T15:31:19Z

@magento run Static Tests

ihor-sviziev · 2020-07-14T20:40:34Z

@AntonEvers from first look - looks good, but let’s wait for test results. Also would be good to cover these changes with some automated tests, I think we need to have integration test there, similar to this https://github.com/magento/magento2/blob/40a787632f36ca67f8fff8c451e1e8d1bdbaf9f6/dev/tests/integration/testsuite/Magento/Setup/Console/Command/DependenciesShowFrameworkCommandTest.php will you be able to cover your change with such test?

@magento run all tests

AntonEvers · 2020-07-15T08:58:58Z

@magento run Static Tests

AntonEvers · 2020-07-16T09:59:36Z

@magento run Static Tests

`bin/magento setup:static-content:deploy --language=all` currently only deploys en_US, instead of the requested "all". In the process repair the language argument in the deployment command. Remove DB dependency and deploy theme specific languages Add deployment config for Admin locale generation Reduce object coupling by introducing a new class Fix code sniffer errors add unit tests Suppress PHPMD.CouplingBetweenObjects resolve static test issues and Semantic Version Checker issue resolve static test results

AntonEvers · 2020-07-16T10:45:31Z

@magento run all tests

ihor-sviziev

Good job! Thank you so much for this improvement!

magento-engcom-team · 2020-07-17T06:36:31Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7853 has been created to process this Pull Request

engcom-Alfa · 2020-07-21T08:34:48Z

@magento create issue

engcom-Alfa · 2020-07-21T10:08:24Z

✔️ QA Passed

Manual testing scenario:

Configure multiple store views with different locales ( in my case en_US, de_DE and fr_FR);
Configure a locale other than en_US for your admin user.
Run in console: bin/magento setup:static-content:deploy --language=all;

Before: ✖️ only en_US are deployed;

After: ✔️ All configured languages are deployed

Run in console:bin/magento setup:static-content:deploy --language=all --exclude-language=en_US

After: ✔️ All configured languages except English are deployed

Run in console: bin/magento setup:static-content:deploy en_US

After: ✔️ Only en_US is deployed

Run in console: bin/magento setup:static-content:deploy -l en_US

After: ✔️ Only en_US is deployed

Run in console: bin/magento setup:static-content:deploy --language=en_US de_DE

After: ✔️ Only de_DE is deployed as the languages argument precedes over the language option

m2-assistant · 2020-07-23T08:57:43Z

Hi @AntonEvers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Jun 29, 2020

magento-engcom-team added Component: Deploy Release Line: 2.4 labels Jun 29, 2020

AntonEvers force-pushed the lang-deploy branch from c87e92b to e665762 Compare June 30, 2020 07:58

VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 8, 2020

VladimirZaets added this to the 2.4.1 milestone Jul 8, 2020

ihor-sviziev self-assigned this Jul 14, 2020

ihor-sviziev added Award: complex Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jul 14, 2020

ihor-sviziev requested changes Jul 14, 2020

View reviewed changes

app/code/Magento/Deploy/Package/PackagePool.php Outdated Show resolved Hide resolved

app/code/Magento/Deploy/Package/PackagePool.php Outdated Show resolved Hide resolved

app/code/Magento/Deploy/Package/PackagePool.php Outdated Show resolved Hide resolved

ghost added Progress: needs update and removed Progress: pending review labels Jul 14, 2020

AntonEvers force-pushed the lang-deploy branch 2 times, most recently from e2b1fcb to 8d2376b Compare July 14, 2020 13:49

ghost added Progress: pending review and removed Progress: needs update labels Jul 14, 2020

AntonEvers force-pushed the lang-deploy branch from eccd2d2 to c18f77d Compare July 14, 2020 15:28

AntonEvers force-pushed the lang-deploy branch from cc130f2 to da400fb Compare July 16, 2020 10:45

ihor-sviziev added the Award: test coverage label Jul 16, 2020

ghost added Progress: pending review and removed Progress: needs update labels Jul 16, 2020

ihor-sviziev approved these changes Jul 17, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Jul 17, 2020

magento-engcom-team added the Component: Setup label Jul 17, 2020

engcom-Alfa self-assigned this Jul 21, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 21, 2020

m2-assistant bot mentioned this pull request Jul 21, 2020

[Issue] Deploy all used locales #29218

Closed

4 tasks

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 21, 2020

engcom-Charlie self-assigned this Jul 21, 2020

engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 21, 2020

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 22, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jul 22, 2020

magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2020

ENGCOM-7853: Deploy all used locales #28922

8bf4e17

magento-engcom-team merged commit 2eb0fe6 into magento:2.4-develop Jul 23, 2020

kierenevans mentioned this pull request Dec 8, 2020

Fix setup:static-content:deploy before 2.4.1 inviqa/harness-base-php#507

Merged

Deploy all used locales #28922

Deploy all used locales #28922

Uh oh!

Conversation

AntonEvers commented Jun 29, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Jun 29, 2020

Uh oh!

AntonEvers commented Jun 29, 2020

Uh oh!

AntonEvers commented Jun 30, 2020

Uh oh!

AntonEvers commented Jun 30, 2020

Uh oh!

VladimirZaets commented Jul 9, 2020 • edited by ihor-sviziev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntonEvers commented Jul 14, 2020

Uh oh!

AntonEvers commented Jul 14, 2020

Uh oh!

AntonEvers commented Jul 14, 2020

Uh oh!

AntonEvers commented Jul 14, 2020

Uh oh!

ihor-sviziev commented Jul 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntonEvers commented Jul 15, 2020

Uh oh!

AntonEvers commented Jul 16, 2020

Uh oh!

AntonEvers commented Jul 16, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jul 17, 2020

Uh oh!

engcom-Alfa commented Jul 21, 2020

Uh oh!

engcom-Alfa commented Jul 21, 2020

Uh oh!

m2-assistant bot commented Jul 23, 2020

Uh oh!

Uh oh!

AntonEvers commented Jun 29, 2020 •

edited by m2-assistant bot

Loading

VladimirZaets commented Jul 9, 2020 •

edited by ihor-sviziev

Loading

ihor-sviziev commented Jul 14, 2020 •

edited

Loading