Skip to content

Redirect to "Options" config path more accurate (in Currency Rate form) #29276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Jul 26, 2020

Description (*)

Redirect to "Currency Option Path" more accurate (Auto open the collapse)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to backend, Stores->Currency Rates
  2. Click "Options"

image

=> Should be redirect to currency options in System config and automatically open the collapse like that:

image

(Now, it is not opened)

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Redirect to "Options" config path more accurate (in Currency Rate form) #29336: Redirect to "Options" config path more accurate (in Currency Rate form)

@m2-assistant
Copy link

m2-assistant bot commented Jul 26, 2020

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar
Copy link
Contributor

rogyar commented Jul 26, 2020

Hi @edenduong. Great improvement thank you.
More kudos for the unit test, good job.
If you could create a separate MFTF test for this case that will check the menu item expanding behavior, you would get even more kudos :)
But if you don't wish to, it's OK.

Thank you.

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 26, 2020
@ghost ghost assigned edenduong Jul 26, 2020
@VladimirZaets
Copy link
Contributor

@magento create issue

@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 30, 2020
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong, thanks for the pull request, it looks great! The changes are approved.

@gabrieldagama
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8066 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8066 has been created to process this Pull Request

@engcom-Echo
Copy link
Contributor

Hi, @edenduong. I will take care of test coverage.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Go to backend, Stores->Currency Rates;
  2. Click "Options";

Before: ✖️ redirected to currency options in System config but not collapsed the tab

Peek 2020-09-04 09-38

After: ✔️ redirected to currency options in System config and automatically opened the collapse

Peek 2020-09-04 09-49

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Sep 7, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Sep 7, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit 6fab465 into magento:2.4-develop Sep 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CurrencySymbol Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. tech-partners-contribution Technology Partner: Magestore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Redirect to "Options" config path more accurate (in Currency Rate form)
7 participants