-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 11 commits into
magento:2.4-develop
from
yolouiese:1703-deleted-tags-not-removed
Aug 19, 2020
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b2b45e6
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese c716884
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese 9a2f265
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese 8d9d0a5
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese 512942e
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese 7e34bc9
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese 0f9189e
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese c4055cc
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese 3b350fd
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese bf77de0
Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…
yolouiese 5f1d43a
magento/magento2#1703: The deleted tags are not removed from Tags dro…
yolouiese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
...diaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryEditAssetRemoveKeywordActionGroup.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
<actionGroup name="AdminMediaGalleryEditAssetRemoveKeywordActionGroup"> | ||
<annotations> | ||
<description>Remove Keywords on the Edit Details panel</description> | ||
</annotations> | ||
<arguments> | ||
<argument name="keyword" type="string"/> | ||
</arguments> | ||
|
||
<click selector="{{AdminEnhancedMediaGalleryEditDetailsSection.removeSelectedKeyword(keyword)}}" stepKey="removeKeyword"/> | ||
</actionGroup> | ||
</actionGroups> |
25 changes: 25 additions & 0 deletions
25
.../Mftf/ActionGroup/AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
<actionGroup name="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup"> | ||
<annotations> | ||
<description>Verifies that the passed comma-separated list of keywords are not present on the View Details panel</description> | ||
</annotations> | ||
<arguments> | ||
<argument name="keywords" type="string"/> | ||
</arguments> | ||
|
||
<grabTextFrom selector="{{AdminEnhancedMediaGalleryViewDetailsSection.keywords}}" stepKey="grabKeywords"/> | ||
<assertStringNotContainsString stepKey="verifyKeywords"> | ||
<actualResult type="variable">grabKeywords</actualResult> | ||
<expectedResult type="string">{{keywords}}</expectedResult> | ||
</assertStringNotContainsString> | ||
</actionGroup> | ||
</actionGroups> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
.../Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyUpdatedTagsTest.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> | ||
<test name="AdminEnhancedMediaGalleryVerifyUpdatedTagsTest"> | ||
<annotations> | ||
<features value="MediaGallery"/> | ||
<useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1703"/> | ||
<title value="User checks if the deleted tags are removed from Edit page, Tags field"/> | ||
<stories value="User checks if the deleted tags are removed from Edit page, Tags field"/> | ||
<testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5064888"/> | ||
<description value="User checks if changes made on the tags are updated from Edit page, Tags field"/> | ||
<severity value="CRITICAL"/> | ||
<group value="media_gallery_ui"/> | ||
</annotations> | ||
<before> | ||
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/> | ||
<actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/> | ||
</before> | ||
<after> | ||
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsDeleteActionGroup" stepKey="deleteImage"/> | ||
</after> | ||
<actionGroup ref="AdminEnhancedMediaGalleryUploadImageActionGroup" stepKey="uploadImage"> | ||
<argument name="image" value="ImageUpload3"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryViewImageDetails" stepKey="viewImageDetails"/> | ||
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsEditActionGroup" stepKey="editImage"/> | ||
<actionGroup ref="AdminMediaGalleryEditAssetAddKeywordActionGroup" stepKey="setKeywords"> | ||
<argument name="keyword" value="UpdatedImageDetails.keyword"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsSaveActionGroup" stepKey="saveImage"> | ||
<argument name="image" value="UpdatedImageDetails"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryVerifyImageKeywordsActionGroup" stepKey="verifyAddedKeywords"> | ||
<argument name="keywords" value="UpdatedImageDetails.keyword"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsEditActionGroup" stepKey="updateImageDetails"/> | ||
<actionGroup ref="AdminMediaGalleryEditAssetRemoveKeywordActionGroup" stepKey="removeKeywords"> | ||
<argument name="keyword" value="{{UpdatedImageDetails.keyword}}"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsSaveActionGroup" stepKey="saveUpdatedImage"> | ||
<argument name="image" value="UpdatedImageDetails"/> | ||
</actionGroup> | ||
<actionGroup ref="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup" stepKey="verifyRemovedKeywords"> | ||
<argument name="keywords" value="{{UpdatedImageDetails.keyword}}"/> | ||
</actionGroup> | ||
</test> | ||
</tests> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
AdminEnhancedMediaGalleryViewImageDetails
should be executed before this step