-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#1709: Modified date is not updated when Editing image Tags the second time #29424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…en Editing image tags - Implement update on modified date on media asset if there are changes on keywords.
Hi @jmonteros422. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Hi @sivaschenko, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ QA Failed
The issue is still reproducible. Modified Date is not updated when editing image Tags
Pull Request state was updated. Re-review required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmonteros422!
Thank you for your contribution!
Could you introduce and Integration Test with data saving to check that 'updated_at' column is updated after save.
Thank you for the review! Okay! |
Hi @chalov-anton , Thank you for the QA, Can you retry modifying the tags after a browser refresh. I am only able to reproduce this because of related issue #29400 . Let me know of the results. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sivaschenko, thank you for the review. |
…ags the second time #29424
Hi @jmonteros422, thank you for your contribution! |
Description (*)
This PR fixes issue #1709 with the media_gallery_asset's updated_at field not being updated if changes are made on the keyword tags. Unit test is adjusted as well.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Need to verify if approach is correct.
Contribution checklist (*)