Set all instances of cache context to be transient

[mlambley]

Description (*)

Cache context has no way to know which items have been cleaned. When an item is added to the context and then cleaned, this is not an issue. But as more items are added and cleaned, those earlier items are cleaned again and again. This results in an exponential performance drain. This PR seeks to remedy this by making all instances of cache context transient.

Fixed Issues (if relevant)

1. Fixes Cache cleaner performance issue when saving multiple products #29275

Manual testing scenarios (*)

$skus = [1000 product skus];
$products = [];
foreach ($skus as $sku) {
	$products[] = $this->productRepository->get($sku, true, 0, true);
}

foreach ($products as $product) {
	$product->setPrice(12);
	$this->productRepository->save($product);
}

Before applying these changes, put a debug in \Magento\Indexer\Model\Indexer\CacheCleaner looking at the value of $identities in cleanCache(). Watch the array grow with each product save, with the same identities being cleaned multiple times. Now apply the changes and see the $identities not grow.

Questions or comments

Please give feedback. Thank you.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mlambley. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Hi @mlambley,
I general your changes looks good to me, but I see that webapi tests are failing now, so seems like your change did some regression.
Could you review failing tests and adjust your code changes accordingly?

Also would be good to cover your changes with some kind of tests, I believe integration tests will fit there. Could you do that?

[sidolov]

@mlambley I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @mlambley, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[duckchip]

I think this PR should be openend again.