Introduced granulated Media Gallery ACL resources #29715

Nazar65 · 2020-08-21T14:19:26Z

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/35

Fixed Issues

Fixes magento/adobe-stock-integration#1487: Introduce granulated Media Gallery ACL resources and enforce for old media gallery

Approval Request

https://jira.corp.magento.com/browse/MC-37384

Manual testing scenarios (*)

** Upload assets
** Edit assets
** Delete assets
** Insert assets into the content
** Create folder
** Delete folder

Create new admin user
Try to apply all mentioned acl resources for this user one by time
Verify functionality in old media gallery && new media gallery

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

… media gallery

m2-assistant · 2020-08-21T14:19:28Z

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Nazar65 · 2020-08-21T14:20:07Z

@magento run all tests

app/code/Magento/MediaGalleryUi/etc/acl.xml

magento-engcom-team · 2020-08-21T14:50:42Z

Hi @BarnyShergold, thank you for the review.
ENGCOM-8057 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

BarnyShergold

Sort order for Create Folder & Delete Folder need to be different values

app/code/Magento/MediaGalleryUi/etc/acl.xml

Nazar65 · 2020-08-28T13:09:59Z

@magento run all test

…o ASI-1487

Nazar65 · 2020-08-28T18:54:59Z

@magento run all tests

Nazar65 · 2020-08-28T19:02:08Z

@magento run all tests

sivaschenko · 2020-09-04T13:52:06Z

@magento run all tests

magento-engcom-team · 2020-09-04T18:03:46Z

Hi @sidolov, thank you for the review.
ENGCOM-8057 has been created to process this Pull Request

sivaschenko · 2020-09-04T18:35:45Z

@magento run all tests

engcom-Bravo · 2020-09-07T12:53:24Z

✔️ QA Passed

Tested the following manual scenarios:

Upload assets
Edit assets
Delete assets
Insert assets into the content
Create folder
Delete folder

Tested the following admin role resources in New Media Gallery:
Media Media Gallery:

Insert assets into the content
Upload assets
Edit asset details
Adobe Stock
Save Preview Image
License images
Delete assets
Create folder
Delete folder

Tested creating a user role on Magento 2.4.0 + ASI 2.0.0-master, and upgrade instance to Magento 2.4.0 + ASI 2.1.0-master

Test scenarios which cover ACL functionality:
https://studio.cucumber.io/projects/131313/test-plan/folders/943908/scenarios/3218882
https://studio.cucumber.io/projects/131313/test-plan/folders/1051731/scenarios/3967955
https://studio.cucumber.io/projects/131313/test-plan/folders/1051731/scenarios/3968678

sivaschenko · 2020-09-07T16:46:16Z

@magento run all tests

sivaschenko · 2020-09-08T11:41:15Z

@magento run Functional Tests B2B,Sample Data Tests B2B

sivaschenko · 2020-09-09T20:56:33Z

SVC Approved. MFTF failures are caused by downtime of 3rd party service (InStorePickup modules). Ready for delivery

…nd enforce for old media gallery #29715

m2-assistant · 2020-09-11T11:03:06Z

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Introduce granulated Media Gallery ACL resources and enforce for old…

771dc31

… media gallery

magento-engcom-team added Component: Cms Component: MediaGalleryUi labels Aug 21, 2020

ghost added the Progress: pending review label Aug 21, 2020

magento-engcom-team added the Release Line: 2.4 label Aug 21, 2020

engcom-Golf added the Project: ASI label Aug 21, 2020

BarnyShergold self-assigned this Aug 21, 2020

BarnyShergold approved these changes Aug 21, 2020

View reviewed changes

app/code/Magento/MediaGalleryUi/etc/acl.xml Outdated Show resolved Hide resolved

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 21, 2020

BarnyShergold requested changes Aug 24, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Aug 24, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 24, 2020

sivaschenko reviewed Aug 24, 2020

View reviewed changes

app/code/Magento/MediaGalleryUi/etc/acl.xml Outdated Show resolved Hide resolved

ghost assigned sivaschenko Aug 24, 2020

Improve acl resources for new media gallery

dd9bdda

Nazar65 changed the title ~~[WIP] Introduce granulated Media Gallery ACL resources and enforce for old media gallery~~ Introduce granulated Media Gallery ACL resources and enforce for old media gallery Aug 28, 2020

Nazar65 added 4 commits August 28, 2020 17:04

Improve button visibility

989139f

Improve button visibility per allowed actions for user

239314d

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

eaa20f2

…o ASI-1487

Improve buttons visibility per user permission

8cdcefd

Code style improvements

43fd057

#29715: Fixed upgrade

0a6156f

sidolov approved these changes Sep 4, 2020

View reviewed changes

ghost assigned sidolov Sep 4, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 4, 2020

magento-engcom-team added Area: Frontend Component: MediaGalleryCmsUi labels Sep 4, 2020

sivaschenko added 2 commits September 4, 2020 19:34

#29715: Fixed tests

253bafb

Merge branch '2.4-develop' into ASI-1487

2448fd8

engcom-Bravo self-assigned this Sep 7, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 7, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 7, 2020

sivaschenko mentioned this pull request Sep 7, 2020

Upgrade script for Media Gallery ACL magento/adobe-stock-integration#1800

Closed

sivaschenko added 2 commits September 7, 2020 17:37

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-1487

cf288e6

#29715: Removed redundant dependency

7296cdf

ghost added Progress: accept and removed Progress: extended testing labels Sep 9, 2020

gabrieldagama mentioned this pull request Sep 11, 2020

Dependency injecting callable objects #1487

Closed

magento-engcom-team pushed a commit that referenced this pull request Sep 11, 2020

ENGCOM-8057: [WIP] Introduce granulated Media Gallery ACL resources a…

6b01272

…nd enforce for old media gallery #29715

magento-engcom-team merged commit e9e7bed into magento:2.4-develop Sep 11, 2020

Introduced granulated Media Gallery ACL resources #29715

Introduced granulated Media Gallery ACL resources #29715

Uh oh!

Conversation

Nazar65 commented Aug 21, 2020 • edited by sivaschenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues

Approval Request

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 21, 2020

Uh oh!

Nazar65 commented Aug 21, 2020

Uh oh!

Uh oh!

magento-engcom-team commented Aug 21, 2020

Uh oh!

BarnyShergold left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nazar65 commented Aug 28, 2020

Uh oh!

Nazar65 commented Aug 28, 2020

Uh oh!

Nazar65 commented Aug 28, 2020

Uh oh!

sivaschenko commented Sep 4, 2020

Uh oh!

magento-engcom-team commented Sep 4, 2020

Uh oh!

sivaschenko commented Sep 4, 2020

Uh oh!

engcom-Bravo commented Sep 7, 2020

Uh oh!

sivaschenko commented Sep 7, 2020

Uh oh!

sivaschenko commented Sep 8, 2020

Uh oh!

sivaschenko commented Sep 9, 2020

Uh oh!

m2-assistant bot commented Sep 11, 2020

Uh oh!

Uh oh!

Nazar65 commented Aug 21, 2020 •

edited by sivaschenko

Loading