-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest #29895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 13 commits into
magento:2.4-develop
from
joweecaquicla:ASI-1794-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test
Sep 14, 2020
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
96ea4d5
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
cbca032
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
ef4813c
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
86e9656
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
f3ea93f
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
8cea7c9
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
27a9bef
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
811861c
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
225f554
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
65690bc
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
e31ab00
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
2485935
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
a7a1038
magento/adobe-stock-integration#1794: [MFTF] Unskip AdminMediaGallery…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...de/Magento/MediaGalleryCatalogUi/Test/Mftf/Data/AdminEnhancedMediaGalleryCategoryData.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd"> | ||
<entity name="TestSubCategory" type="category"> | ||
<data key="name" unique="suffix">TestSubCategory</data> | ||
<data key="name_lwr" unique="suffix">testsubcategory</data> | ||
<data key="is_active">true</data> | ||
<data key="include_in_menu">true</data> | ||
</entity> | ||
</entities> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for introducing this entity instead of
SimpleSubCategory
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sivaschenko There were instances when the test would fail because the category name did not match, to be more specific, it was the hashed suffix on the category name that did not match so I introduced the new entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joweecaquicla what was the reason of not matching hashed suffix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sivaschenko I was not able to investigate that issue thoroughly as I was not able to replicate it in my local environment.