Fixed issue 29920 - "Item in Cart" not pluralized correctly #29923

saphaljha · 2020-09-07T07:58:33Z

Description (*)

When adding more then 1 qty of an item in cart and check checkout page order summary section text 'Items in Cart' is pluralized correctly or not

Related Pull Requests

Fixed Issues (if relevant)

Fixes "Item in Cart" not pluralized correctly #29920

Manual testing scenarios (*)

Manually Tested
Added MFTF

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

updating magento

m2-assistant · 2020-09-07T07:58:35Z

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

saphaljha · 2020-09-07T07:59:31Z

@magento run all tests

rogyar

Hi @saphaljha. Thank you for your contribution.
Please, fill out the PR description according to the template (including steps to reproduce and other details).
Also, I would ask you to cover your fix using a simple MFTF test. Thank you!

saphaljha · 2020-09-07T09:35:19Z

Hello @rogyar,

Thank you for review, I will update it as suggested.

Thank you

saphaljha · 2020-09-08T05:09:25Z

@magento run all tests

saphaljha · 2020-09-08T08:42:02Z

@magento run Functional Tests B2B

rogyar · 2020-09-10T10:00:23Z

...ftf/Test/StorefrontGuestCheckoutTest/StorefrontCheckoutSummaryItemsInCartLabelPluralized.xml

+  */
+-->
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="StorefrontCheckoutSummaryItemsInCartLabelPluralized">


Hi @saphaljha awesome work! Thank you. One minor thing, please, add the "...Test" suffix to the test name and the file name correspondingly

Suggested change

<test name="StorefrontCheckoutSummaryItemsInCartLabelPluralized">

<test name="StorefrontCheckoutSummaryItemsInCartLabelPluralizedTest">

@rogyar Thank you :) , I have updated commit as per your suggestions, thank you for review.

saphaljha · 2020-10-31T09:09:34Z

Hello @rogyar ,

You mean to say I need to cover MFTF as per cases like for minicart mentioned above by @engcom-Alfa ?
Because I have covered it in MFTF but flow is different.

Thanks to guide me in that.

rogyar · 2020-11-04T13:09:53Z

Hi @saphaljha. I mean, we need to adjust assertions for some of the existing tests since they (tests) still expect the old values. Please, check the failing tests for details.

Thank you.

saphaljha · 2020-11-06T14:33:41Z

@magento run all tests

saphaljha · 2020-11-06T17:20:43Z

@magento run WebAPI Tests

magento-engcom-team · 2020-11-10T10:46:46Z

Hi @rogyar, thank you for the review.
ENGCOM-8447 has been created to process this Pull Request

engcom-Bravo · 2020-11-10T14:40:07Z

✔️ QA Passed

Manual testing scenario

Add a single product to the cart in a quantity of 3. (Or, any quantity greater than one.)

Actual Result: on Magento 2.4-develop
In the minicart the text "2 Item in Cart" appears.

In the checkout order summary the text "3 Item in Cart" appears.

After applying changes provided in this PR
In the minicart the text "2 Items in Cart" appears.

In the checkout order summary the text "3 Items in Cart" appears.

Also rechecked with one single item in Cart 1 Item in Cart is displayed

…tly #29923

m2-assistant · 2020-11-13T13:35:16Z

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Saphal Jha added 8 commits April 12, 2020 20:28

Merge pull request #38 from magento/2.4-develop

1ea3208

updating magento

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

f01de6c

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

8186622

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

992de7a

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

6489f07

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

a883b69

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

ce26200

Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop

ee32160

ghost added the Progress: pending review label Sep 7, 2020

magento-engcom-team added Area: Frontend Component: Checkout Release Line: 2.4 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Sep 7, 2020

rogyar self-assigned this Sep 7, 2020

rogyar requested changes Sep 7, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Sep 7, 2020

saphaljha changed the title ~~Fixed issue 29920~~ Fixed issue 29920 - "Item in Cart" not pluralized correctly Sep 8, 2020

saphaljha requested a review from rogyar September 8, 2020 10:51

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 8, 2020

rogyar requested changes Sep 10, 2020

View reviewed changes

rogyar added Award: bug fix Award: MFTF test coverage labels Sep 10, 2020

saphaljha added 4 commits October 31, 2020 14:32

checkout - correctly pluralized 'Item in Cart'

4c36fad

Added MFTF for checking pluralized text

558b7d5

updated code as per suggestion

b034b4b

Fixed count label issue in minicart and covered MFTF

49573eb

Updated label in other mftf

15c6380

saphaljha force-pushed the fixed-issue-29920 branch from 08564cb to 15c6380 Compare November 6, 2020 13:25

saphaljha requested a review from engcom-Alfa November 7, 2020 02:57

rogyar approved these changes Nov 10, 2020

View reviewed changes

m2-community-project bot assigned rogyar Nov 10, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Nov 10, 2020

engcom-Bravo self-assigned this Nov 10, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 10, 2020

m2-community-project bot added Progress: testing in progress Progress: accept and removed Progress: ready for testing Progress: testing in progress labels Nov 10, 2020

gabrieldagama mentioned this pull request Nov 13, 2020

"Item in Cart" not pluralized correctly #29920

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Nov 13, 2020

ENGCOM-8447: Fixed issue 29920 - "Item in Cart" not pluralized correc…

d0994c3

…tly #29923

magento-engcom-team merged commit 727a042 into magento:2.4-develop Nov 13, 2020

magento-engcom-team removed Award: MFTF test coverage Award: bug fix labels Nov 13, 2020

sidolov added the Award: MFTF test coverage label Nov 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed issue 29920 - "Item in Cart" not pluralized correctly #29923

Fixed issue 29920 - "Item in Cart" not pluralized correctly #29923

Uh oh!

saphaljha commented Sep 7, 2020 •

edited

Loading

Uh oh!

m2-assistant bot commented Sep 7, 2020

Uh oh!

saphaljha commented Sep 7, 2020

Uh oh!

rogyar left a comment •

edited

Loading

Uh oh!

saphaljha commented Sep 7, 2020

Uh oh!

saphaljha commented Sep 8, 2020

Uh oh!

saphaljha commented Sep 8, 2020

Uh oh!

rogyar Sep 10, 2020

Uh oh!

saphaljha Sep 10, 2020 •

edited

Loading

Uh oh!

saphaljha commented Oct 31, 2020

Uh oh!

rogyar commented Nov 4, 2020

Uh oh!

saphaljha commented Nov 6, 2020

Uh oh!

saphaljha commented Nov 6, 2020

Uh oh!

magento-engcom-team commented Nov 10, 2020

Uh oh!

engcom-Bravo commented Nov 10, 2020

Uh oh!

m2-assistant bot commented Nov 13, 2020

Uh oh!

Uh oh!

	<test name="StorefrontCheckoutSummaryItemsInCartLabelPluralized">
	<test name="StorefrontCheckoutSummaryItemsInCartLabelPluralizedTest">

Fixed issue 29920 - "Item in Cart" not pluralized correctly #29923

Fixed issue 29920 - "Item in Cart" not pluralized correctly #29923

Uh oh!

Conversation

saphaljha commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Sep 7, 2020

Uh oh!

saphaljha commented Sep 7, 2020

Uh oh!

rogyar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saphaljha commented Sep 7, 2020

Uh oh!

saphaljha commented Sep 8, 2020

Uh oh!

saphaljha commented Sep 8, 2020

Uh oh!

rogyar Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

saphaljha Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saphaljha commented Oct 31, 2020

Uh oh!

rogyar commented Nov 4, 2020

Uh oh!

saphaljha commented Nov 6, 2020

Uh oh!

saphaljha commented Nov 6, 2020

Uh oh!

magento-engcom-team commented Nov 10, 2020

Uh oh!

engcom-Bravo commented Nov 10, 2020

Manual testing scenario

Uh oh!

m2-assistant bot commented Nov 13, 2020

Uh oh!

Uh oh!

saphaljha commented Sep 7, 2020 •

edited

Loading

rogyar left a comment •

edited

Loading

saphaljha Sep 10, 2020 •

edited

Loading