Skip to content

[MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup #29962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 18, 2020
Merged

[MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup #29962

merged 7 commits into from
Sep 18, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Sep 9, 2020 •
edited by m2-assistant bot
Loading

This PR introduce AdminClickInvoiceButtonIntoOrderActionGroup

Resolved issues:

  1. resolves [Issue] [WIP][MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup #29982: [WIP][MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 9, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203 Usik2203 changed the title [MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup [WIP][MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup Sep 9, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

rogyar
rogyar reviewed Sep 10, 2020
View reviewed changes
app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminClickInvoiceButtonIntoOrderActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminClickInvoiceButtonIntoOrderActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest renaming this action group slightly, since "Into" does not describe the purpose accurately. Something like

"AdminClickInvoiceButtonOrderViewActionGroup"

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost ghost assigned rogyar Sep 10, 2020
rogyar
rogyar reviewed Sep 10, 2020
View reviewed changes
app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminClickInvoiceButtonIntoOrderActionGroup.xml Outdated

<click selector="{{AdminOrderDetailsMainActionsSection.invoice}}" stepKey="clickInvoiceAction"/>
<waitForPageLoad stepKey="waitForProductPage"/>
<seeInCurrentUrl url="{{AdminInvoiceNewPage.url}}" stepKey="seeOrderInvoiceUrl"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having an assertion in this action group is a good idea. But it's not a commonly used practice. This approach may slow down the existing test execution routine. Also, this action group will not be potentially usable in case if the invoice functionality will appear in a popup in the future. So I would suggest being ascetic here. If the action group "clicks", it should not perform extra actions that don't directly relate to the clicking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 10, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 10, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 10, 2020
Closed
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@Usik2203 Usik2203 changed the title [WIP][MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup [MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup Sep 14, 2020
@ghost ghost assigned Usik2203 Sep 14, 2020
@ghost ghost assigned sidolov Sep 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8210 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Risk: low labels Sep 14, 2020
@gabrieldagama
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@gabrieldagama
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@gabrieldagama
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2020
@sidolov
ENGCOM-8210: [MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup #…
6304979 
…29962
@magento-engcom-team magento-engcom-team merged commit 0f3d3b8 into magento:2.4-develop Sep 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar left review comments

@sidolov sidolov sidolov approved these changes

Assignees

@rogyar rogyar

@sidolov sidolov

@Usik2203 Usik2203

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Component: CatalogInventory Component: ConfigurableProduct Component: Reports Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [WIP][MFTF] Add AdminClickInvoiceButtonIntoOrderActionGroup
5 participants
@Usik2203 @sidolov @magento-engcom-team @gabrieldagama @rogyar