-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix compatibility with phpunit 9.3 in integration and api functional tests #30170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with phpunit 9.3 in integration and api functional tests #30170
Conversation
Hi @ihor-sviziev. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Seems like similar changes should be done in magento2/dev/tests/api-functional/testsuite/Magento/WebApiTest.php Lines 14 to 16 in d8ca81c
|
d5524e7
to
5fbf456
Compare
5fbf456
to
62cad12
Compare
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Verified locally and works as expected both with 9.3 and 9.1
Personally, I'm super happy with you proceeding the PHPUnit upgrades! Awesome job.
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA Passed Case 1. Integration testsManual testing scenario:
Before: ✖️ PhpUnit 9.3 After: ✔️ PhpUnit 9.1 ✔️ PhpUnit 9.3 Case 2. Api-functional tests
After: ✔️ PhpUnit 9.1 ✔️ PhpUnit 9.3 |
…i functional tests #30170
Hi @ihor-sviziev, thank you for your contribution! |
Description (*)
Fixes compatibility with phpunit 9.3 and keeping backward compatibility with phpunit <9.3, similar what was done in symfony symfony/phpunit-bridge@9a87dd7
✔ Before my changes on phpunit 9.1:

❌ Before my changes on phpunit 9.3:
✔ After my changes on phpunit 9.1:


✔ After my changes on phpunit 9.3:
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)