fixing arguments for method in getStatusByState

[sarron93]

Description (*)

if you will checking this condition
echo $select = $this->getConnection()->select() ->from(['sss' => $this->stateTable, []]) ->where('state = ?', $state) ->limit(1) ->columns(['status']);
then you see
SELECT sss.*, sss.statusFROMsales_order_status_stateASsss WHERE (state = 'complete') LIMIT 1
but method getStatusByState return is correct value - because the status of a certain state should return. But if this code is rewritten to get the state, then we will also get the status, this is all due to the incorrect parameter in the from method

Manual testing scenarios (*)

1. echo $select in getStatusByState method should return sql like this
   SELECT sss.statusFROMsales_order_status_stateASsss WHERE (state = 'complete') LIMIT 1

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] fixing arguments for method in getStatusByState #30173: fixing arguments for method in getStatusByState

[m2-assistant]

Hi @sarron93. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sarron93]

@magento run all tests

[sidolov]

@magento create issue

[rogyar]

Hi @sarron93.

Good catch. We may consider this part covered by the following test

magento2/app/code/Magento/Sales/Test/Mftf/Test/AdminUnassignCustomOrderStatusTest.xml

Line 10 in 928c270

<test name="AdminUnassignCustomOrderStatusTest">

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8264 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Result:
Before:

After:

[engcom-Delta]

Note: Functional Tests EE are failed

[m2-assistant]

Hi @sarron93, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.