#30255: Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed #30391

shikhamis11 · 2020-10-10T04:07:24Z

Fixed #30255 "The coupon code has been accepted." message remains after a Coupon Code was removed

Preconditions

Create simple product

Create Customer with address

First Name: John
Last Name: Doe
Email Address: [email protected](use real mail)
Company: Magento
Address: 6161 West Centinela Avenue
City: Culver City
State/Province: California (CA)
Zip/Postal Code: 90230
Country: United States
Telephone: 555-55-555-55

Go to Admin -> Marketing -> Cart Price Rules: click "Add New Rule"

Fill all required fields
    "Coupon" select Specific Coupon
    "Coupon Code" = 1111
In "Action" section
    "Apply" select "Percent of product price discount"
    "Discount Amount" = 50
click "Save" button

Steps:

Go to admin -> sales -order -> create new order -> select customer
Add Products => simple product
Apply Coupon Code => 1111
remove Coupon Code

(/) Expected result
"The coupon code has been accepted." message should disappear

(x) Actual result
"The coupon code has been accepted." message is still present

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…ains after a Coupon Code was removed Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed

m2-assistant · 2020-10-10T04:07:26Z

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rodrigowebjump · 2020-10-10T04:15:49Z

@magento give me test instance

magento-deployment-service · 2020-10-10T04:15:51Z

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T04:21:37Z

Hi @rodrigowebjump, here is your Magento Instance: https://abc4ca6d605a710c7fac378118341a81.instances.magento-community.engineering
Admin access: https://abc4ca6d605a710c7fac378118341a81.instances.magento-community.engineering/admin_3fe9
Login: cc9d8dd7
Password: fee0d1a91b20

milindsingh · 2020-10-10T04:34:26Z

#dmcdindia2020

pramod-mishra · 2020-10-10T04:50:03Z

#dmcdindia2020

magento-engcom-team · 2020-10-10T04:50:06Z

@pramod-mishra thank you for joining. Please accept team invitation here and self-assign the issue.

rodrigowebjump · 2020-10-10T04:56:35Z

Hi @shikhamis11 Thanks for your contribution.

Please could you cover your fix by autotests (MFTF)?
Thanks

pramod-mishra · 2020-10-10T05:00:51Z

@magento give me test instance

magento-deployment-service · 2020-10-10T05:00:54Z

Hi @pramod-mishra. Thank you for your request. I'm working on Magento instance for you.

shikhamis11 · 2020-10-10T05:00:56Z

@rodrigowebjump Thanks for the review . I am working on to add MFTF coverage for the issue

magento-deployment-service · 2020-10-10T05:01:30Z

Hi @pramod-mishra, here is your Magento Instance: https://abc4ca6d605a710c7fac378118341a81.instances.magento-community.engineering
Admin access: https://abc4ca6d605a710c7fac378118341a81.instances.magento-community.engineering/admin_3fe9
Login: cc9d8dd7
Password: fee0d1a91b20

rodrigowebjump · 2020-10-10T05:08:15Z

@magento give me 2.4-develop instance

magento-deployment-service · 2020-10-10T05:08:17Z

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T05:12:45Z

Hi @rodrigowebjump, here is your Magento Instance: https://abc4ca6d605a710c7fac378118341a81-2-4-develop.instances.magento-community.engineering
Admin access: https://abc4ca6d605a710c7fac378118341a81-2-4-develop.instances.magento-community.engineering/admin_731d
Login: 725ea307
Password: 47909753e936

rodrigowebjump · 2020-10-10T05:53:34Z

Hi @shikhamis11

Apparently the issue is being caused because there is no message returned when the coupon is removed.
A suggestion for this case is to return a message informing that the coupon was removed in the backend request process (like occurs in the storefront)

The current JS behavior does not remove the previous message if a empty is received in the response. Since there is a lot of requests happening there, my recommendation is to not change this behavior for now because we can create some undesirable
result.

…ns after a Coupon Code was removed reverted previous changes and updated requested changes

shikhamis11 · 2020-10-10T09:16:06Z

@magento give me test instance

engcom-Charlie · 2020-11-05T09:02:07Z

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderToVerifyApplyAndRemoveCouponCodeTest.xml

+            <severity value="CRITICAL"/>
+            <testCaseId value="MC-37386"/>


@shikhamis11 could you please update severity and testCaseId?
Thank you.

<severity value="AVERAGE"/> <testCaseId value="MC-38919"/>

updated `severity` and `testCaseId` for added MFTF test

engcom-Charlie · 2020-11-05T09:56:08Z

@magento run all tests

gabrieldagama

Hi @shikhamis11, I believe we might have an issue with the mftf, can you check it?

gabrieldagama · 2020-11-05T15:24:12Z

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderToVerifyApplyAndRemoveCouponCodeTest.xml

+            <magentoCLI command="config:set {{DisableFlatRateConfigData.path}} {{DisableFlatRateConfigData.value}}"
+                        stepKey="disableFlatRate"/>


I believe flat rate is enabled by default, by disabling it we may have made other tests flaky. I guess you can keep the CLI to enable it, but remove this one.

removed disable flat rate step from after action

shikhamis11 · 2020-11-05T16:14:04Z

@magento run all tests

gabrieldagama · 2020-11-06T09:44:56Z

@magento run Functional Tests EE

magento-engcom-team · 2020-11-06T09:46:32Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-8426 has been created to process this Pull Request

engcom-Alfa · 2020-11-06T12:32:06Z

✔️ QA Passed

…ge remains after a Coupon Code was removed #30391

m2-assistant · 2020-11-13T13:34:59Z

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#30255: Fixed "The coupon code has been accepted." message rem…

f54561e

…ains after a Coupon Code was removed Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Area: Frontend Component: Sales Release Line: 2.4 Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner labels Oct 10, 2020

rodrigowebjump self-assigned this Oct 10, 2020

rodrigowebjump self-requested a review October 10, 2020 04:12

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 10, 2020

magento#30255: Fixed The coupon code has been accepted. message remai…

16e962d

…ns after a Coupon Code was removed reverted previous changes and updated requested changes

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: ready for testing labels Nov 5, 2020

engcom-Charlie reviewed Nov 5, 2020

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: extended testing labels Nov 5, 2020

magento#30255: Fixed The coupon code has been accepted message

28376be

updated `severity` and `testCaseId` for added MFTF test

gabrieldagama suggested changes Nov 5, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 5, 2020

magento#30255: Fixed The coupon code has been accepted message

d011456

removed disable flat rate step from after action

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Nov 6, 2020

gabrieldagama approved these changes Nov 6, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Nov 6, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Nov 6, 2020

m2-community-project bot added Progress: extended testing Progress: accept and removed Progress: testing in progress labels Nov 6, 2020

gabrieldagama mentioned this pull request Nov 13, 2020

"The coupon code has been accepted." message remains after a Coupon Code was removed #30255

Closed

magento-engcom-team pushed a commit that referenced this pull request Nov 13, 2020

ENGCOM-8426: #30255: Fixed "The coupon code has been accepted." messa…

32c4c3e

…ge remains after a Coupon Code was removed #30391

magento-engcom-team merged commit 2ccc605 into magento:2.4-develop Nov 13, 2020

		<magentoCLI command="config:set {{DisableFlatRateConfigData.path}} {{DisableFlatRateConfigData.value}}"
		stepKey="disableFlatRate"/>

#30255: Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed #30391

#30255: Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed #30391

Uh oh!

Conversation

shikhamis11 commented Oct 10, 2020

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 10, 2020

Uh oh!

rodrigowebjump commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

milindsingh commented Oct 10, 2020

Uh oh!

pramod-mishra commented Oct 10, 2020

Uh oh!

magento-engcom-team commented Oct 10, 2020

Uh oh!

rodrigowebjump commented Oct 10, 2020

Uh oh!

pramod-mishra commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

shikhamis11 commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

rodrigowebjump commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

rodrigowebjump commented Oct 10, 2020

Uh oh!

shikhamis11 commented Oct 10, 2020

Uh oh!

engcom-Charlie Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Nov 5, 2020

Uh oh!

gabrieldagama left a comment

Choose a reason for hiding this comment

Uh oh!

gabrieldagama Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented Nov 5, 2020

Uh oh!

gabrieldagama commented Nov 6, 2020

Uh oh!

magento-engcom-team commented Nov 6, 2020

Uh oh!

engcom-Alfa commented Nov 6, 2020

Uh oh!

m2-assistant bot commented Nov 13, 2020

Uh oh!

Uh oh!