Update insert.js

[ashvin0009]

#30361 : Fixed an empty window opens after the second click of the "Add Attribute" button

Description

Fixes #30361 - an empty window opens after the second click of the "Add Attribute" button

Fixed Issues

1. Fixes magento/magento2#<30361>

Manual testing scenarios

1. Go to Catalog -> Products -> Add New Product
2. Click on the "Add Attribute" button (Upper right corner)
3. Click on the "Create New Attribute" button
4. Close the opened window
5. Click on the "Create New Attribute" button again
6. The blank window doesn't show up and there is no error in dev console. Add attribute feature is also working fine.

Contribution checklist (*)

• [Y] Pull request has a meaningful description of its purpose
• [Y] All commits are accompanied by meaningful commit messages
• [Y] All new or changed code is covered with unit/integration tests (if applicable)
• [Y] All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ashvin0009. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ashvin0009]

@magento run all tests

[rodrigowebjump]

@magento give me test instance

[magento-deployment-service]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @rodrigowebjump, here is your Magento Instance: https://d36899afc3bbf1411054c4a8e4647319.instances.magento-community.engineering
Admin access: https://d36899afc3bbf1411054c4a8e4647319.instances.magento-community.engineering/admin_674d
Login: 6409c883
Password: 757423ffa875

[sivaschenko]

#dmcdindia2020

[rogyar]

Hi @ashvin0009. Thank you for your contribution. The following case seems to be already covered by the following PR

#30400

Since the mentioned PR has been created earlier, I have to mark this one as a duplicate. In case if author of the mentioned PR will not proceed working on the PR, you may continue with your PR.

Thank you.

[ihor-sviziev]

Hi @ashvin0009,
Thank you so much for your contribution!
Unfortunately, I see that we already have merged PR that fixes the same issue #30400.
I'm closing this PR as not relevant anymore.

[m2-assistant]

Hi @ashvin0009, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.