Customer Attributes Options with option group fixed #30421

nitishcs6 · 2020-10-10T10:27:01Z

\Magento\Customer\Ui\Component\Listing\AttributeRepository::getOptionArray method fails to return correct options for attribute with option groupsi.e store_id (Create In).

Description (*)

\Magento\Customer\Ui\Component\Listing\AttributeRepository::getOptionArray method fails to return correct options for attribute with option groupsi.e store_id (Create In).
It fails for all attributes with option group in "options" index.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Use the \Magento\Customer\Ui\Component\Listing\AttributeRepository in any form or grid and render select options with option groups.

$this->attributeRepository->getMetadataByCode($code)
Before

{
  "attribute_code": "store_id",
  "frontend_input": "select",
  "frontend_label": "Create In",
  "backend_type": "static",
  "options": [
    {
      "label": "MyStore Saudi",
      "value": null,
      "__disableTmpl": true
    },
    {
      "label": "MyStore Saudi Store",
      "value": null,
      "__disableTmpl": true
    },
    {
      "label": "MyStore Kuwait",
      "value": null,
      "__disableTmpl": true
    },
    {
      "label": "MyStore Kuwait Store",
      "value": null,
      "__disableTmpl": true
    }
  ],
  "is_used_in_grid": false,
  "is_visible_in_grid": false,
  "is_filterable_in_grid": false,
  "is_searchable_in_grid": false,
  "validation_rules": [],
  "required": true,
  "entity_type_code": "customer"
}

After

{
  "attribute_code": "store_id",
  "frontend_input": "select",
  "frontend_label": "Create In",
  "backend_type": "static",
  "options": [
    {
      "label": "MyStore Saudi",
      "value": null,
      "__disableTmpl": true
    },
    {
      "label": "    MyStore Saudi Store",
      "value": [
        {
          "label": "Saudi English",
          "value": "2",
          "__disableTmpl": true
        },
        {
          "label": "Saudi Arabic",
          "value": "3",
          "__disableTmpl": true
        }
      ],
      "__disableTmpl": true
    },
    {
      "label": "MyStore Kuwait",
      "value": null,
      "__disableTmpl": true
    },
    {
      "label": "MyStore Kuwait Store",
      "value": [
        {
          "label": "Kuwait English",
          "value": "4",
          "__disableTmpl": true
        },
        {
          "label": "Kuwait Arabic",
          "value": "5",
          "__disableTmpl": true
        }
      ],
      "__disableTmpl": true
    }
  ],
  "is_used_in_grid": false,
  "is_visible_in_grid": false,
  "is_filterable_in_grid": false,
  "is_searchable_in_grid": false,
  "validation_rules": [],
  "required": true,
  "entity_type_code": "customer"
}

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Customer Attributes Options with option group fixed #30422: Customer Attributes Options with option group fixed

m2-assistant · 2020-10-10T10:27:04Z

Hi @nitishcs6. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

nitishcs6 · 2020-10-10T10:30:37Z

@magento create issue

nitishcs6 · 2020-10-10T10:33:30Z

#dmcdindia2020

rogyar

Hi @nitishcs6.Thank you for your contribution. According to the definition of done all changes should be covered by autotests. Could I ask you to cover your changes with an integration test, please?

Thank you!

rogyar · 2020-10-10T14:04:12Z

@magento run all tests

engcom-Charlie · 2020-10-20T08:33:26Z

Hi @nitishcs6 could you please cover your changes by integration tests?
Thank you.

milindsingh · 2020-10-20T12:29:56Z

Hi @nitishcs6 could you please cover your changes by integration tests?
Thank you.

@engcom-Charlie can you suggest any sample integration test case for this pr?

engcom-Charlie · 2020-10-21T09:54:48Z

@nitishcs6 @milindsingh unfortunately there is no integration test for \Magento\Customer\Ui\Component\Listing\AttributeRepository but feel free to create it.
You can assert the output of \Magento\Customer\Ui\Component\Listing\AttributeRepository::getMetadataByCode('store_id').
Let me know if you will have any question.

engcom-Charlie · 2020-10-23T08:52:23Z

Hi, @nitishcs6 please cover your changes by integration tests. Otherwise, we can't proceed with your PR.
Thank you.

milindsingh · 2020-10-23T09:17:30Z

@engcom-Charlie I will add the test cases this weekend.

engcom-Charlie · 2020-10-28T10:00:14Z

@nitishcs6 @milindsingh do you have any updates about test coverage?
Thank you.

engcom-Charlie · 2020-10-30T09:01:20Z

@nitishcs6 @milindsingh please cover your changes by integration test. Otherwise, we can't proceed with your PR.
Thank you.

engcom-Charlie · 2020-11-02T09:45:33Z

@nitishcs6 @milindsingh I will take care of automated tests.
Thank you.

magento-engcom-team · 2020-11-16T22:08:43Z

Hi @sidolov, thank you for the review.
ENGCOM-8465 has been created to process this Pull Request

engcom-Alfa · 2020-11-18T08:40:52Z

✔️ QA Passed

Preconditions:

(for example)

Main Website:

Main Website Store:

Default Store View ;
Second Store View;
Third Store View;

Second Store:

English Store View;
French Store View;

Manual testing scenario:

Use the \Magento\Customer\Ui\Component\Listing\AttributeRepository in any form or grid and render select options with option groups;
$this->attributeRepository->getMetadataByCode($code)

Before: ✖️ the method doesn't return correct options

$test = {array} [12]
 attribute_code = "store_id"
 frontend_input = "select"
 frontend_label = "Create In"
 backend_type = "static"
 options = {array} [3]
  0 = {array} [3]
   label = "Main Website"
   value = null
   __disableTmpl = true
  1 = {array} [3]
   label = "    Main Website Store"
   value = null
   __disableTmpl = true
  2 = {array} [3]
   label = "    Second Store"
   value = null
   __disableTmpl = true
 is_used_in_grid = false
 is_visible_in_grid = false
 is_filterable_in_grid = false
 is_searchable_in_grid = false
 validation_rules = {array} [0]
 required = true
 entity_type_code = "customer"

After: ✔️ the method returns correct options

$test = {array} [12]
 attribute_code = "store_id"
 frontend_input = "select"
 frontend_label = "Create In"
 backend_type = "static"
 options = {array} [3]
  0 = {array} [3]
   label = "Main Website"
   value = {array} [0]
   __disableTmpl = true
  1 = {array} [3]
   label = "    Main Website Store"
   value = {array} [3]
    0 = {array} [3]
     label = "    Default Store View"
     value = "1"
     __disableTmpl = true
    1 = {array} [3]
     label = "    Second Store View"
     value = "2"
     __disableTmpl = true
    2 = {array} [3]
     label = "    Third Store View"
     value = "3"
     __disableTmpl = true
   __disableTmpl = true
  2 = {array} [3]
   label = "    Second Store"
   value = {array} [2]
    0 = {array} [3]
     label = "    English Store View"
     value = "4"
     __disableTmpl = true
    1 = {array} [3]
     label = "    French Store View"
     value = "5"
     __disableTmpl = true
   __disableTmpl = true
 is_used_in_grid = false
 is_visible_in_grid = false
 is_filterable_in_grid = false
 is_searchable_in_grid = false
 validation_rules = {array} [0]
 required = true
 entity_type_code = "customer"

m2-assistant · 2020-11-27T17:41:51Z

Hi @nitishcs6, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Customer Attributes Options with option group fixed

b5a64c7

magento-engcom-team added the Component: Customer label Oct 10, 2020

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Release Line: 2.4 Partner: Born Group partners-contribution Pull Request is created by Magento Partner labels Oct 10, 2020

m2-assistant bot mentioned this pull request Oct 10, 2020

[Issue] Customer Attributes Options with option group fixed #30422

Closed

4 tasks

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 10, 2020

rogyar self-assigned this Oct 10, 2020

rogyar requested changes Oct 10, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Oct 10, 2020

engcom-Charlie self-assigned this Oct 20, 2020

ghost removed the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Oct 20, 2020

engcom-Charlie added 2 commits November 2, 2020 11:46

Merge branch '2.4-develop' into customer-select-option-fix

57a4510

add integration test

9dc798f

m2-community-project bot added Progress: pending review Progress: review and removed Progress: pending review labels Nov 9, 2020

sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 16, 2020

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 16, 2020

sidolov approved these changes Nov 16, 2020

View reviewed changes

m2-community-project bot assigned sidolov Nov 16, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Nov 16, 2020

engcom-Alfa self-assigned this Nov 17, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Nov 17, 2020

m2-community-project bot added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Nov 18, 2020

engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 18, 2020

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: ready for testing Progress: extended testing labels Nov 18, 2020

magento-engcom-team closed this in 3378823 Nov 27, 2020

magento-engcom-team pushed a commit that referenced this pull request Nov 27, 2020

ENGCOM-8465: Customer Attributes Options with option group fixed #30421

b75b1e1

magento-engcom-team merged commit 3378823 into magento:2.4-develop Nov 27, 2020

m2-community-project bot removed the Progress: accept label Nov 27, 2020

Customer Attributes Options with option group fixed #30421

Customer Attributes Options with option group fixed #30421

Uh oh!

Conversation

nitishcs6 commented Oct 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Oct 10, 2020

Uh oh!

nitishcs6 commented Oct 10, 2020

Uh oh!

nitishcs6 commented Oct 10, 2020

Uh oh!

rogyar left a comment

Choose a reason for hiding this comment

Uh oh!

rogyar commented Oct 10, 2020

Uh oh!

engcom-Charlie commented Oct 20, 2020

Uh oh!

milindsingh commented Oct 20, 2020

Uh oh!

engcom-Charlie commented Oct 21, 2020

Uh oh!

engcom-Charlie commented Oct 23, 2020

Uh oh!

milindsingh commented Oct 23, 2020

Uh oh!

engcom-Charlie commented Oct 28, 2020

Uh oh!

engcom-Charlie commented Oct 30, 2020

Uh oh!

engcom-Charlie commented Nov 2, 2020

Uh oh!

magento-engcom-team commented Nov 16, 2020

Uh oh!

engcom-Alfa commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Nov 27, 2020

Uh oh!

Uh oh!

nitishcs6 commented Oct 10, 2020 •

edited

Loading

engcom-Alfa commented Nov 18, 2020 •

edited

Loading