Prevent multiple quotations of the same word

[denchev]

Description (*)

When there is a long search phrase and some of the words in that phrase has quotes in it, the algorithm for creating a search with synonyms will create multiple scenarios of that phrase. But for each scenario the quoted word would be escaped over and over again. For a long phrase that builds a very large number of escape \ and reaches a limit for the regular expression.

This fix makes sure that the escape happens only once per scenario.

This also seems to be a regression introduced by this commit 38c4a3e because when reverted to ce1263d the functionality works even without the fix from this PR.

Related Pull Requests

None

Fixed Issues (if relevant)

1. Fixes Elastic Search issue with Synonyms #30104

Manual testing scenarios (*)

1. Enable Elasticsearch 6+
2. Add a product with a long name with a slash / in it.
   Example: LSS 3/8"X3/4"X25' EZ-PULL 1/2" INS SWEAT LINESET W/90 END BEND SUCTION LINE INSULATED
3. Add Search Synonyms with a word belongs to the product name.
   Example: center end boot,torpedo boot,horn boot,register boot center end,register boot torpedo
4. Search in the frontend for that exact product.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @denchev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[denchev]

@magento run all tests

[swnsma]

Hi @denchev,

Please check failed static tests.
I believe, in this case you can use:
// phpcs:disable Magento2.Functions.DiscouragedFunction

[denchev]

@magento run Integration Tests

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8466 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Was checked case from Manual testing scenarios
❌ Before:

✔️ After:

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @denchev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.