-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix acl.xml inconsistency. LoginAsCustomerAssistance #30681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix acl.xml inconsistency. LoginAsCustomerAssistance #30681
Conversation
Hi @DiegoSana. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me test instance |
Hi @DiegoSana. Thank you for your request. I'm working on Magento instance for you. |
Hi @DiegoSana, here is your Magento Instance: https://a885c577caf5b108fc9109e2d965c2b0.instances.magento-community.engineering |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DiegoSana,
Could you sign Adobe CLA, otherwise we can't accept your PR?
@magento run Integration Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, address requested changes
@magento run Integration Tests |
done it |
@sidolov is there something else that i need to do? |
@magento run Functional Tests B2B |
1 similar comment
@magento run Functional Tests B2B |
Hi @ihor-sviziev, thank you for the review. |
@DiegoSana thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️
After: ✔️ Acces to the admin dashboard with your user and password |
Hi @DiegoSana, thank you for your contribution! |
Fix acl.xml inconsistency when not all Magento_LoginAsCustomer* are enabled. See issue #30680
Description (*)
Magento 2.4.1 instance.
When Magento_LoginAsCustomerAssistance is enable without Magento_LoginAsCustomerAdminUi or Magento_LoginAsCustomerLog enabled, the acl.xml generated by magento, leavs the resource Magento_LoginAsCustomer::login without title attribute. This produce a fatal error trying to access to the admin panel.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
'Magento_LoginAsCustomer' => 0,
'Magento_LoginAsCustomerAdminUi' => 0,
'Magento_LoginAsCustomerApi' => 0,
'Magento_LoginAsCustomerAssistance' => 1,
'Magento_LoginAsCustomerFrontendUi' => 0,
'Magento_LoginAsCustomerLog' => 0,
'Magento_LoginAsCustomerLogging' => 0,
'Magento_LoginAsCustomerPageCache' => 0,
'Magento_LoginAsCustomerQuote' => 0,
'Magento_LoginAsCustomerSales' => 0,
'Magento_LoginAsCustomerWebsiteRestriction' => 0,
Questions or comments
Contribution checklist (*)