Fix acl.xml inconsistency. LoginAsCustomerAssistance

[DiegoSana]

Fix acl.xml inconsistency when not all Magento_LoginAsCustomer* are enabled. See issue #30680

Description (*)

Magento 2.4.1 instance.
When Magento_LoginAsCustomerAssistance is enable without Magento_LoginAsCustomerAdminUi or Magento_LoginAsCustomerLog enabled, the acl.xml generated by magento, leavs the resource Magento_LoginAsCustomer::login without title attribute. This produce a fatal error trying to access to the admin panel.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento upgrade 2.4.0 to 2.4.1 - Login As Customer acl.xml title attribute missing #30680

Manual testing scenarios (*)

1. Magento 2.4.1 instance
2. Magento_LoginAsCustomer* like this...
   'Magento_LoginAsCustomer' => 0,
'Magento_LoginAsCustomerAdminUi' => 0,
'Magento_LoginAsCustomerApi' => 0,
'Magento_LoginAsCustomerAssistance' => 1,
'Magento_LoginAsCustomerFrontendUi' => 0,
'Magento_LoginAsCustomerLog' => 0,
'Magento_LoginAsCustomerLogging' => 0,
'Magento_LoginAsCustomerPageCache' => 0,
'Magento_LoginAsCustomerQuote' => 0,
'Magento_LoginAsCustomerSales' => 0,
'Magento_LoginAsCustomerWebsiteRestriction' => 0,
3. Login into the admin

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @DiegoSana. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[DiegoSana]

@magento give me test instance

[magento-deployment-service]

Hi @DiegoSana. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @DiegoSana, here is your Magento Instance: https://a885c577caf5b108fc9109e2d965c2b0.instances.magento-community.engineering
Admin access: https://a885c577caf5b108fc9109e2d965c2b0.instances.magento-community.engineering/admin_5a1e
Login: 776c8199
Password: 86c05f6a9241

[DiegoSana]

@magento run all tests

[ihor-sviziev]

Hi @DiegoSana,
Could you sign Adobe CLA, otherwise we can't accept your PR?

[ihor-sviziev]

@magento run Integration Tests

[sidolov]

Please, address requested changes

[DiegoSana]

@magento run Integration Tests

[DiegoSana]

Hi @DiegoSana,
Could you sign Adobe CLA, otherwise we can't accept your PR?

done it

[DiegoSana]

@sidolov is there something else that i need to do?
A few minutes ago all checka was green.

[DiegoSana]

@magento run Functional Tests B2B

[DiegoSana]

@magento run Functional Tests B2B

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8405 has been created to process this Pull Request

[magento-engcom-team]

@DiegoSana thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Magento 2.4.0
2. LoginAsCustomer disabled
   'Magento_LoginAsCustomer' => 0,
'Magento_LoginAsCustomerAdminUi' => 0,
'Magento_LoginAsCustomerApi' => 0,
'Magento_LoginAsCustomerFrontendUi' => 0,
'Magento_LoginAsCustomerLog' => 0,
'Magento_LoginAsCustomerLogging' => 0,
'Magento_LoginAsCustomerPageCache' => 0,
'Magento_LoginAsCustomerQuote' => 0,
'Magento_LoginAsCustomerSales' => 0,
'Magento_LoginAsCustomerWebsiteRestriction' => 0,

Manual testing scenario:

1. Upgrade to Magento 2.4.1;
2. Try to access to the admin;

Before: ✖️

Exception #0 (LogicException): Could not create an acl object: Invalid Document 
Element 'resource': The attribute 'title' is required but missing.
Line: 13

After: ✔️ Acces to the admin dashboard with your user and password

[m2-assistant]

Hi @DiegoSana, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.