-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[MFTF] Added AdminClickGetShippingMethodsAndRatesActionGroup and AdminSelectFixedShippingMethodActionGroup #30779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] Added AdminClickGetShippingMethodsAndRatesActionGroup and AdminSelectFixedShippingMethodActionGroup #30779
Conversation
Hi @Usik2203. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B |
@magento create issue |
|
||
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
<actionGroup name="AdminSelectFixedShippingMethodActionGroup"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a little bit confusing how exactly this action group selects the "Fixed" shipping method. Maybe it makes sense to name it as AdminSelectFirstShippingMethodActionGroup
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogyar
This Action Group selectFixed
Shipping Method not First
Due to this element
<element name="shippingMethod" type="button" selector="//label[contains(text(), 'Fixed')]" timeout="60"/>
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Sales/Test/Mftf/Section/AdminInvoicePaymentShippingSection.xml#L19
I think if i will name this action group as AdminSelectFirstShippingMethodActionGroup
it will be more confusable because it's not true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks
Hi @rogyar, thank you for the review. |
QA not applicable |
@magento run all tests |
…roup and AdminSelectFixedShippingMethodActionGroup #30779
Hi @Usik2203, thank you for your contribution! |
This PR provides
AdminSelectFixedShippingMethodActionGroup
AdminClickGetShippingMethodsAndRatesActionGroup
Resolved issues: