Removed redundant header issue in grid cells while adding grouped product items after changing attribute set

[saphaljha]

Description (*)

Removed redundant header issue in grid cells while adding grouped product items after changing attribute set

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Redundant header generated while add a product to grouped product #30911

Manual testing scenarios (*)

1. Manually tested

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[saphaljha]

@magento run all tests

[saphaljha]

@magento run Functional Tests CE, Integration Tests, Functional Tests B2B

[gabrieldagama]

Hi @saphaljha, thanks for your contribution!

Can you cover the changes with automated tests? I would recommend updating the app/code/Magento/GroupedProduct/Test/Unit/Ui/DataProvider/Product/Form/Modifier/GroupedTest.php test to validate/cover your changes.

Thanks.

[gabrieldagama]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

[saphaljha]

Hi @saphaljha, thanks for your contribution!

Can you cover the changes with automated tests? I would recommend updating the app/code/Magento/GroupedProduct/Test/Unit/Ui/DataProvider/Product/Form/Modifier/GroupedTest.php test to validate/cover your changes.

Thanks.

Hello @gabrieldagama ,

Ok sure, I'll try to cover it with MFTF, also I'll work necessary update in unit test.

Thank you

[engcom-Hotel]

@magento run Integration Tests

[engcom-Charlie]

@saphaljha I'll take care of test coverage.

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8545 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Precondition:

Sample Data

Manual testing scenario:

1. Go Admin > Catalog > Products;
2. Select Grouped Product from drop-down of Add Product button;
3. In the new product page, at Attribute Set select, choose Top;
4. Scroll down to the tab Grouped Products and try to add a new product;

Before: ✖️ Redundant headers generated

After: ✔️ Redundant headers were not generated

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.