Skip to content

Issue 30387 - Add formatted price to Money type #31242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

dineshvb
Copy link

@dineshvb dineshvb commented Dec 10, 2020

Description (*)

  • This is a new feature request.
  • A new field named 'formatted' is added to the GRAPHQL Money type.
  • Frontend developers will feel easy to render the content since the new formatted price is added.

Fixed Issues (if relevant)

  1. Fixes [GraphQl] Add Formatted price to Money Type. #30387

Manual testing scenarios (*)

  1. Price Tiers and Price Range of a product

Sample Request

{
 products(
  filter:{
    name:{
      match: "paint"
    }
  }
){
  items{
    name
    price_tiers{
      quantity
     discount{
      amount_off
      percent_off
    }
      final_price{
        value
        currency
        formatted
      }
    }
    price_range{
      maximum_price{
        regular_price{
          value
          currency
          formatted
        }
      }
    }
  }
}
}

Sample Response

{
  "data": {
    "products": {
      "items": [
        {
          "name": "paint",
          "price_tiers": [
            {
              "quantity": 7,
              "discount": {
                "amount_off": 2,
                "percent_off": 20
              },
              "final_price": {
                "value": 8,
                "currency": "INR",
                "formatted": "₹8.00"
              }
            },
            {
              "quantity": 14,
              "discount": {
                "amount_off": 3,
                "percent_off": 30
              },
              "final_price": {
                "value": 7,
                "currency": "INR",
                "formatted": "₹7.00"
              }
            },
            {
              "quantity": 28,
              "discount": {
                "amount_off": 4,
                "percent_off": 40
              },
              "final_price": {
                "value": 6,
                "currency": "INR",
                "formatted": "₹6.00"
              }
            }
          ],
          "price_range": {
            "maximum_price": {
              "regular_price": {
                "value": 10,
                "currency": "INR",
                "formatted": "₹10.00"
              }
            }
          }
        }
      ]
    }
  }
}
  1. Removing a GiftCard from user account(Mutation)

Sample Request

mutation {
  removeGiftCardFromCart(
    input: {
      cart_id: {cart id}
      gift_card_code: {gift card code}
    }
  ) {
    cart {
      applied_gift_cards {
        code
        applied_balance{
          currency
          formatted
          value
        }
        current_balance{
          value
          currency
          formatted
        }
      }
    }
  }
}

Sample Response

{
  "data": {
    "removeGiftCardFromCart": {
      "cart": {
        "applied_gift_cards": [
          {
            "code": "010LBCQKJ4Z5",
            "applied_balance": {
              "currency": "INR",
              "formatted": "₹100.00",
              "value": 100
            },
            "current_balance": {
              "value": 100,
              "currency": "INR",
              "formatted": "₹100.00"
            }
          }
        ]
      }
    }
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Dinesh V B added 2 commits December 10, 2020 16:54
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @dineshvb. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: multiple Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: review Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

[GraphQl] Add Formatted price to Money Type.
4 participants