Skip to content

Add action items for stale bot comment #31542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

ihor-sviziev
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor Author

cc @sivaschenko

@sivaschenko sivaschenko requested a review from sdzhepa January 5, 2021 13:13
@sivaschenko
Copy link
Member

Thanks for the PR @ihor-sviziev . The message suggesting to return the attention to the stale issue might help to prevent closing of overlooked important issues.

@sdzhepa what do you think about the comment change?

@sivaschenko sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 5, 2021
@sivaschenko sivaschenko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 5, 2021
@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Jan 5, 2021

@sivaschenko exactly!
Right now message says that we'll just close it and not provides any reasons behind it.

The idea behind closing stale issues - is not just closing them without any reason, but closing not important ones. It means if someone could make some progress and fix the issue - why not? If no one touches it - it's fine to close it.

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-8598 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor Author

@sivaschenko maybe we should somehow stress that we would like to focus on the most important issues and not spend time on not important ones?

@sivaschenko
Copy link
Member

@ihor-sviziev I believe we had a lot of communication about the priorities introduction last year.

How do you think we can stress it?

@ihor-sviziev
Copy link
Contributor Author

@sivaschenko not all the contributors are reading all Magento articles. For people that don’t really know the idea behind it might be not clear why would you close the issue. Maybe adding some links to the articles would be good.
Or do you feel it’s clear enough now?

@sivaschenko
Copy link
Member

@ihor-sviziev I wouldn't include the link to a post in the comment. I think the current content is enough, a simple response in comment will reset the stale counter and the issue will not be closed.

@ihor-sviziev
Copy link
Contributor Author

@sivaschenko ok, so are you going to merge this PR?

@sivaschenko
Copy link
Member

@ihor-sviziev it's in the queue to mainline now

@magento-engcom-team magento-engcom-team merged commit bd1273d into magento:2.4-develop Jan 19, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 19, 2021

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev deleted the patch-4 branch January 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants