Skip to content

Removed CliIndexerReindexActionGroup action group usage for CatalogRule module #31564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

Removed CliIndexerReindexActionGroup action group usage for CatalogRule module #31564

merged 1 commit into from
Jan 14, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 6, 2021 •
edited by m2-assistant bot
Loading

Description

Remove CliIndexerReindexActionGroup action group usage or change value for it from tests to improve execution time for the CatalogRule, Downloadable and Indexer modules.

Resolved issues:

  1. resolves [Issue] Removed CliIndexerReindexActionGroup action group usage for CatalogRule module #31575: Removed CliIndexerReindexActionGroup action group usage for CatalogRule module

@sergiy-v
Removed usage or changed value of CliIndexerReindexActionGroup action…
6390bbf 
… group for CatalogRule, Downloadable and Indexer modules
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 6, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@rogyar rogyar self-assigned this Jan 6, 2021
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 6, 2021

@magento run Semantic Version Checker

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 6, 2021

@magento run Functional Tests CE

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 6, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 6, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 6, 2021
Closed
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 7, 2021

@magento run Functional Tests CE

1 similar comment
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 7, 2021

@magento run Functional Tests CE

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 7, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8608 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 8, 2021
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Jan 8, 2021 •
edited
Loading

Note: Functional Tests CE are failed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 8, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 9, 2021

@magento run Functional Tests EE

magento-engcom-team pushed a commit that referenced this pull request Jan 14, 2021
@gabrieldagama
ENGCOM-8608: Removed CliIndexerReindexActionGroup action group usage …
a4ed768 
…for CatalogRule module #31564
@magento-engcom-team magento-engcom-team merged commit 3fdc5b2 into magento:2.4-develop Jan 14, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CatalogRule Component: Downloadable Component: Indexer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliIndexerReindexActionGroup action group usage for CatalogRule module
7 participants
@sergiy-v @sidolov @magento-engcom-team @engcom-Delta @engcom-Foxtrot @rogyar @gabrieldagama