[MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32226

AnnaAPak · 2021-02-19T13:08:40Z

Description (*)

The test covers the 30256 Unexpected unchecking of "Append Comments" check-box issue

Related Pull Requests

#31422

Manual testing scenarios (*)

Start order creating in Admin
Add product
Provide a comment
Assert if the "Append Comment" checkbox is checked
Select payment method
Select shipping method
Assert if the "Append Comment" checkbox is checked
Place the order
On the Order Details page check if a customer is notified of the comment

Resolved issues:

resolves [Issue] WIP [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32381: WIP [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue

m2-assistant · 2021-02-19T13:08:42Z

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2021-02-19T13:11:48Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

shikhamis11

hi @AnnaAPak Thank you for the Pull Request.
I believe to reproduce the issue you need to add a comment in order before selecting the shipping methods.
so the steps will be like

Start order creating in Admin
Add product
Provide shipping/billing information
Add Comment
Assert if the "Append Comment" checkbox is checked
Select payment method
Select shipping method
Assert if the "Append Comment" checkbox is checked
Place the order
On the Order Details page check if a customer is notified of the comment

AnnaAPak · 2021-02-21T14:46:22Z

Hi @shikhamis11,
thank you, I did miss the step with providing a comment (in the description, but in the test we have it) - corrected now.

shikhamis11 · 2021-02-21T14:59:36Z

@AnnaAPak thank you for update. I would like you to add comment in order before selecting shipping method. As per the original issue , the append checkbox is unchecked while getting shipping rate if there is already comment added.

AnnaAPak · 2021-02-21T18:29:55Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

AnnaAPak · 2021-02-21T21:02:11Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

shikhamis11 · 2021-02-22T05:38:18Z

hi @AnnaAPak
Thank you for the update.
can you add one more step to make sure if the append comment checkbox is checked after [provideComment] step ?
I have shared steps here #32226 (review)

changed click Get shipping methods to conditional one

AnnaAPak · 2021-02-28T12:55:01Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

AnnaAPak · 2021-02-28T21:00:08Z

@magento run Functional Tests EE

gabrieldagama · 2021-03-04T17:54:58Z

@magento create issue

shikhamis11 · 2021-03-09T05:25:21Z

@magento run all tests

engcom-Foxtrot · 2021-05-06T08:46:22Z

@AnnaAPak are you going to continue with this PR?

engcom-Foxtrot · 2021-05-28T14:41:57Z

@magento run all tests

magento-automated-testing · 2021-05-28T14:42:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-05-31T08:34:43Z

@magento run Functional Tests EE, WebAPI Tests

magento-automated-testing · 2021-05-31T08:34:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

AnnaAPak · 2021-05-31T08:59:35Z

@engcom-Foxtrot sure, I will do my best to complete it till EOW. Thanks.

shikhamis11 · 2021-05-31T10:33:31Z

@AnnaAPak can you check with the last commit of @engcom-Foxtrot the scrolling issue is fixed?
also, remove WIP if it is completed

AnnaAPak · 2021-06-30T11:51:17Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

magento-automated-testing · 2021-06-30T11:51:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-06-30T14:10:25Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-06-30T14:10:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-07-01T10:32:08Z

Failing tests are not related to this PR

shikhamis11 · 2021-07-01T10:34:37Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-07-01T11:01:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-07-01T11:10:52Z

Hi @shikhamis11, thank you for the review.
ENGCOM-9137 has been created to process this Pull Request

engcom-Charlie · 2021-08-11T07:43:51Z

✔️ QA Passed

The provided MFTF test case is working fine and green in build. Please find the Allure report for the same.

…Append Comments" check-box issue #32226

m2-assistant · 2021-08-27T16:56:28Z

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

AnnaAPak added 2 commits February 19, 2021 15:06

created AdminCreateOrderWithCheckedAppendCommentCheckboxTest

24fb08b

Merge branch '2.4-develop' into append-comment

fc4e310

magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 19, 2021

shikhamis11 requested changes Feb 20, 2021

View reviewed changes

m2-community-project bot assigned shikhamis11 Feb 20, 2021

m2-community-project bot added the Progress: needs update label Feb 20, 2021

reordered steps

0201396

fix for EE/B2B

77bb71e

added check after provideCommentStep

1f258dc

changed click Get shipping methods to conditional one

AnnaAPak force-pushed the append-comment branch from 907a7c5 to 1f258dc Compare February 28, 2021 12:54

AnnaAPak changed the title ~~[MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue~~ WIP [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue Feb 28, 2021

added scroll to fix EE test

c0adb56

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2021

m2-assistant bot mentioned this pull request Mar 4, 2021

[Issue] WIP [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32381

Closed

Merge branch '2.4-develop-mainline' into append-comment

e712a14

AnnaAPak changed the title ~~WIP [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue~~ [MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue Jun 30, 2021

shikhamis11 approved these changes Jul 1, 2021

View reviewed changes

shikhamis11 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Progress: needs update labels Jul 1, 2021

m2-community-project bot added the Progress: ready for testing label Jul 1, 2021

m2-community-project bot added the Progress: on hold label Jul 1, 2021

shikhamis11 removed the Progress: on hold label Jul 1, 2021

engcom-Charlie self-assigned this Aug 10, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 11, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Aug 11, 2021

magento-engcom-team pushed a commit that referenced this pull request Aug 27, 2021

ENGCOM-9137: [MFTF] Coverage for the 30256 Unexpected unchecking of "…

7ae870b

…Append Comments" check-box issue #32226

magento-engcom-team merged commit bba967b into magento:2.4-develop Aug 27, 2021

[MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32226

[MFTF] Coverage for the 30256 Unexpected unchecking of "Append Comments" check-box issue #32226

Uh oh!

Conversation

AnnaAPak commented Feb 19, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Manual testing scenarios (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Feb 19, 2021

Uh oh!

AnnaAPak commented Feb 19, 2021

Uh oh!

shikhamis11 left a comment

Choose a reason for hiding this comment

Uh oh!

AnnaAPak commented Feb 21, 2021

Uh oh!

shikhamis11 commented Feb 21, 2021

Uh oh!

AnnaAPak commented Feb 21, 2021

Uh oh!

AnnaAPak commented Feb 21, 2021

Uh oh!

shikhamis11 commented Feb 22, 2021

Uh oh!

AnnaAPak commented Feb 28, 2021

Uh oh!

AnnaAPak commented Feb 28, 2021

Uh oh!

gabrieldagama commented Mar 4, 2021

Uh oh!

shikhamis11 commented Mar 9, 2021

Uh oh!

engcom-Foxtrot commented May 6, 2021

Uh oh!

engcom-Foxtrot commented May 28, 2021

Uh oh!

magento-automated-testing bot commented May 28, 2021

Uh oh!

shikhamis11 commented May 31, 2021

Uh oh!

magento-automated-testing bot commented May 31, 2021

Uh oh!

AnnaAPak commented May 31, 2021

Uh oh!

shikhamis11 commented May 31, 2021

Uh oh!

AnnaAPak commented Jun 30, 2021

Uh oh!

magento-automated-testing bot commented Jun 30, 2021

Uh oh!

shikhamis11 commented Jun 30, 2021

Uh oh!

magento-automated-testing bot commented Jun 30, 2021

Uh oh!

shikhamis11 commented Jul 1, 2021

Uh oh!

shikhamis11 commented Jul 1, 2021

Uh oh!

magento-automated-testing bot commented Jul 1, 2021

Uh oh!

magento-engcom-team commented Jul 1, 2021

Uh oh!

engcom-Charlie commented Aug 11, 2021

Uh oh!

m2-assistant bot commented Aug 27, 2021

Uh oh!

Uh oh!

AnnaAPak commented Feb 19, 2021 •

edited by m2-assistant bot

Loading