Update ramsey/uuid to php8 compatible version #32614

ihor-sviziev · 2021-03-29T06:43:26Z

Description (*)

Right now not all dependencies are ready.
Issues:

allure-framework/allure-php-api:1.1.8 depends on ramsey/uuid: ^3.0.
✔ Only version allure-framework/allure-php-api:1.3.0 and above allow to install ramsey/uuid: ^3 | ^4
allure-framework/allure-phpunit:1.3.1 depends on allure-framework/allure-php-api: ~1.1.0.
✔ There is available version allure-framework/allure-phpunit:1.4.0
allure-framework/allure-codeception:1.4.4 depends on allure-framework/allure-php-api: ~1.1.8.
✔ There is available version allure-framework/allure-codeception:1.5.0
magento/magento2-functional-testing-framework:3.4.0 depends on allure-framework/allure-codeception:~1.4.0 that isn't compatible with version 1.5.0
🟡 There no available versions that support allure-framework/allure-codeception:1.5.0;
- ✔Fixed by Update allure-codeception in order to support php8 magento2-functional-testing-framework#825, available in the php8-develop branch
❌ There no available versions that support PHP 8 - will be fixed in Php8 support magento2-functional-testing-framework#826

For now, I get it resolved using aliases.
I executed following commands:

composer require ramsey/uuid allure-framework/allure-codeception:"1.5.0 as 1.4.5" allure-framework/allure-phpunit:"dev-master as 1.3.2" --update-with-dependencies
composer require --dev allure-framework/allure-codeception:"1.5.0 as 1.4.5" allure-framework/allure-phpunit:"dev-master as 1.3.2"

Also, I replaced in all places Yandex\Allure\Adapter\AllureAdapter with Yandex\Allure\PhpUnit\AllurePhpUnit, as class was renamed between these versions: https://github.com/allure-framework/allure-phpunit/compare/1.2.4..1.3.1

Requires MFTF changes from magento/magento2-functional-testing-framework#825

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/538

Fixed Issues (if relevant)

Fixes Update ramsey/uuid dependency to PHP 8 compatible version #31777

m2-assistant · 2021-03-29T06:43:29Z

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2021-03-29T08:04:11Z

@magento run all tests

ihor-sviziev · 2021-03-29T08:50:12Z

@magento run Static Tests, Unit Tests

ihor-sviziev · 2021-03-29T11:02:50Z

@magento run all tests

ihor-sviziev · 2021-03-29T15:36:15Z

@magento run Functional Tests EE, Integration Tests

Install magento functional tests from PR

ihor-sviziev · 2021-03-30T06:37:29Z

@magento run all tests

…amsey/uuid # Conflicts: # composer.lock

ihor-sviziev · 2021-03-31T08:04:56Z

@magento run all tests

sivaschenko · 2021-04-06T16:28:54Z

Update of allure-framework/allure-phpunit version #31296

Install magento functional tests from php8-develop branch

ihor-sviziev · 2021-04-07T13:51:51Z

@magento run all tests

ihor-sviziev · 2021-04-13T09:45:10Z

Finally! we can update the allure/allure-phpunit package!
allure-framework/allure-phpunit#52 (comment)
https://packagist.org/packages/allure-framework/allure-phpunit#1.4.0

…msey/uuid # Conflicts: # composer.json # composer.lock

Update allure-framework/allure-phpunit to stable version

ihor-sviziev · 2021-04-13T11:09:28Z

@magento run all tests

ihor-sviziev · 2021-04-13T14:03:27Z

Basically, this PR is waiting for:

Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296
❌ there should be fixed test failures caused by class rename during allure-framework/allure-phpunit update
MFTF release that will contain changes from Update allure-codeception in order to support php8 magento2-functional-testing-framework#825 -
✔ so far, we can merge this PR even with installed MFTF from php8-develop branch and later on just switch to stable versino

sivaschenko · 2021-04-28T09:12:36Z

#31296 is merged, I will update composer.json and lock and add the EE PR

sivaschenko · 2021-04-28T10:22:19Z

@magento run Static Tests

ihor-sviziev · 2021-04-28T12:04:24Z

@magento run all tests

ihor-sviziev · 2021-04-28T14:17:09Z

@magento run Integration Tests

ihor-sviziev · 2021-04-29T06:24:28Z

@magento run Functional Tests EE

magento-automated-testing · 2021-04-29T06:24:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-05-05T19:29:19Z

@ihor-sviziev could you please resolve conflict

…into php8-update-ramsey/uuid

sivaschenko · 2021-05-05T22:31:02Z

@ihor-sviziev MFTF 3.5.1 is released. Updated the PR and rerunning the tests

@magento run all tests

magento-automated-testing · 2021-05-05T22:31:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-05-06T03:11:43Z

@magento run WebAPI Tests

magento-automated-testing · 2021-05-06T03:11:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-05-06T06:58:48Z

Hi @sivaschenko, thank you for the review.
ENGCOM-9073 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

m2-assistant · 2021-05-08T21:10:52Z

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update ramsey/uuid to php8 compatible version

67ecd86

ihor-sviziev mentioned this pull request Mar 29, 2021

Dependencies updated, output dir cleanup fixed, tests fixed, system t… allure-framework/allure-phpunit#52

Merged

ihor-sviziev mentioned this pull request Mar 29, 2021

Update ramsey/uuid dependency to PHP 8 compatible version #31777

Closed

ihor-sviziev added the Project: PHP8 label Mar 29, 2021

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 29, 2021

Update ramsey/uuid to php8 compatible version

7d29b3c

Update ramsey/uuid to php8 compatible version

418872f

Install magento functional tests from PR

ihor-sviziev mentioned this pull request Mar 30, 2021

Update allure-codeception in order to support php8 magento/magento2-functional-testing-framework#825

Merged

5 tasks

Merge remote-tracking branch 'origin/php8-develop' into php8-update-r…

e7c461d

…amsey/uuid # Conflicts: # composer.lock

Update ramsey/uuid to php8 compatible version

b5d972f

Install magento functional tests from php8-develop branch

ihor-sviziev changed the base branch from php8-develop to 2.4-develop April 12, 2021 12:39

ihor-sviziev added 2 commits April 13, 2021 13:54

Merge remote-tracking branch 'origin/2.4-develop' into php8-update-ra…

b733b71

…msey/uuid # Conflicts: # composer.json # composer.lock

Update ramsey/uuid to php8 compatible version

2c18c9e

Update allure-framework/allure-phpunit to stable version

ihor-sviziev mentioned this pull request Apr 13, 2021

Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296

Merged

ihor-sviziev marked this pull request as ready for review April 21, 2021 09:29

ihor-sviziev added Project: PHP8 and removed Project: PHP8 labels Apr 21, 2021

magento#31777: Updated ramsey/uuid in framework composer.json

3c24e96

ihor-sviziev changed the title ~~[WIP] Update ramsey/uuid to php8 compatible version~~ Update ramsey/uuid to php8 compatible version Apr 28, 2021

m2-community-project bot added the Progress: pending review label Apr 28, 2021

ihor-sviziev requested a review from sivaschenko April 29, 2021 12:05

sivaschenko added 2 commits May 5, 2021 23:23

Merge branch '2.4-develop' of github.com:magento-commerce/magento2ce …

5ecb737

…into php8-update-ramsey/uuid

magento#31777: Update composer json and lock

d9178a4

sivaschenko added Award: advanced Award: category of expertise labels May 5, 2021

sivaschenko approved these changes May 6, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko May 6, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels May 6, 2021

magento-engcom-team added Release Line: 2.4 Component: Composer labels May 6, 2021

magento-engcom-team merged commit 94cc576 into magento:2.4-develop May 8, 2021

magento-engcom-team removed Award: advanced Award: category of expertise labels May 8, 2021

ihor-sviziev deleted the php8-update-ramsey/uuid branch May 9, 2021 04:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ramsey/uuid to php8 compatible version #32614

Update ramsey/uuid to php8 compatible version #32614

ihor-sviziev commented Mar 29, 2021 •

edited by sivaschenko

Loading

m2-assistant bot commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 30, 2021

ihor-sviziev commented Mar 31, 2021

sivaschenko commented Apr 6, 2021

ihor-sviziev commented Apr 7, 2021

ihor-sviziev commented Apr 13, 2021 •

edited

Loading

ihor-sviziev commented Apr 13, 2021

ihor-sviziev commented Apr 13, 2021 •

edited

Loading

sivaschenko commented Apr 28, 2021

sivaschenko commented Apr 28, 2021

ihor-sviziev commented Apr 28, 2021

ihor-sviziev commented Apr 28, 2021

ihor-sviziev commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

Den4ik commented May 5, 2021

sivaschenko commented May 5, 2021

magento-automated-testing bot commented May 5, 2021

ihor-sviziev commented May 6, 2021

magento-automated-testing bot commented May 6, 2021

magento-engcom-team commented May 6, 2021

m2-assistant bot commented May 8, 2021

Update ramsey/uuid to php8 compatible version #32614

Update ramsey/uuid to php8 compatible version #32614

Conversation

ihor-sviziev commented Mar 29, 2021 • edited by sivaschenko Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

m2-assistant bot commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Mar 30, 2021

ihor-sviziev commented Mar 31, 2021

sivaschenko commented Apr 6, 2021

ihor-sviziev commented Apr 7, 2021

ihor-sviziev commented Apr 13, 2021 • edited Loading

ihor-sviziev commented Apr 13, 2021

ihor-sviziev commented Apr 13, 2021 • edited Loading

sivaschenko commented Apr 28, 2021

sivaschenko commented Apr 28, 2021

ihor-sviziev commented Apr 28, 2021

ihor-sviziev commented Apr 28, 2021

ihor-sviziev commented Apr 29, 2021

magento-automated-testing bot commented Apr 29, 2021

Den4ik commented May 5, 2021

sivaschenko commented May 5, 2021

magento-automated-testing bot commented May 5, 2021

ihor-sviziev commented May 6, 2021

magento-automated-testing bot commented May 6, 2021

magento-engcom-team commented May 6, 2021

m2-assistant bot commented May 8, 2021

ihor-sviziev commented Mar 29, 2021 •

edited by sivaschenko

Loading

ihor-sviziev commented Apr 13, 2021 •

edited

Loading

ihor-sviziev commented Apr 13, 2021 •

edited

Loading