Improve JS Translation DataProviderTest #32689

navarr · 2021-04-07T17:02:19Z

Description (*)

Currently, DataProviderTest checks that the entire dictionary matches only its translations. When third party extensions are installed that have translation files, this test may fail.

This fix ensures that it is only testing the task it is performing.

Related Pull Requests

Test Failure in magento/ext-vertex#96

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Improve JS Translation DataProviderTest #39243: Improve JS Translation DataProviderTest

Currently, DataProviderTest checks that the entire dictionary matches only its translations. When third party extensions are installed that have translation files, this test may fail. This fix ensures that it is only testing the task it is performing.

m2-assistant · 2021-04-07T17:02:22Z

Hi @navarr. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

navarr · 2021-04-07T17:07:07Z

@magento run Integration Tests

ihor-sviziev · 2021-04-08T05:31:38Z

@magento run all tests

ihor-sviziev · 2021-04-08T09:31:58Z

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

eduard13

Hi @navarr, could you please check my question below and suggested changes?
Thank you.

dev/tests/integration/testsuite/Magento/Translation/Model/Js/DataProviderTest.php

Co-authored-by: Eduard Chitoraga <[email protected]>

navarr · 2021-04-08T14:26:56Z

@magento run all tests

navarr · 2021-04-08T14:27:27Z

@eduard13 I've applied your suggestions. I default to static since it's the most flexible, but you're right - there's no real reason for late static binding here.

navarr · 2021-04-08T18:10:56Z

@mageto run Functional Tests EE, Functional Tests B2B

ihor-sviziev · 2021-04-09T05:28:02Z

@magento run Functional Tests EE, Functional Tests B2B

magento-engcom-team · 2021-04-09T05:29:50Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8995 has been created to process this Pull Request

ihor-sviziev · 2021-04-15T09:52:56Z

@magento run Functional Tests B2B, Functional Tests EE

ihor-sviziev · 2021-04-23T07:48:40Z

@magento run Functional Tests B2B, Functional Tests EE

Den4ik · 2021-05-05T19:28:14Z

@magento run Functional Tests B2B, Functional Tests EE

magento-automated-testing · 2021-05-05T19:28:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-05-06T03:45:14Z

@magento run Functional Tests EE

magento-automated-testing · 2021-05-06T03:45:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-07-16T08:32:53Z

Hi @eduard13, thank you for the review.
ENGCOM-8995 has been created to process this Pull Request

magento-engcom-team · 2021-07-16T08:55:43Z

Hi @Den4ik, thank you for the review.
ENGCOM-8995 has been created to process this Pull Request

engcom-Charlie · 2024-10-07T06:59:01Z

@magento run all tests

engcom-Charlie · 2024-10-07T12:34:07Z

@magento create issue

engcom-Charlie · 2024-10-07T12:53:05Z

Hi @navarr,

Thank you for your contribution!

Manual testing is not required for this PR as its making the changes in test assertions. Code looks good and the build is green, hence considering it as QA passed and moving it to Merge In Progress.

Thank you!

magento-engcom-team added Release Line: 2.4 Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner labels Apr 7, 2021

mrtuvn added Award: MFTF test coverage Cleanup Component: Translation labels Apr 8, 2021

ihor-sviziev added Risk: low Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Apr 8, 2021

ihor-sviziev self-assigned this Apr 8, 2021

m2-community-project bot added the Progress: review label Apr 8, 2021

ihor-sviziev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 8, 2021

ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Apr 8, 2021

eduard13 reviewed Apr 8, 2021

View reviewed changes

m2-community-project bot assigned eduard13 Apr 8, 2021

eduard13 removed Award: MFTF test coverage Cleanup labels Apr 8, 2021

Use self instead of static for referring to constants

ef9539a

Co-authored-by: Eduard Chitoraga <[email protected]>

eduard13 added the Priority: P3 May be fixed according to the position in the backlog. label Apr 8, 2021

ihor-sviziev approved these changes Apr 9, 2021

View reviewed changes

m2-community-project bot removed the Progress: review label Apr 9, 2021

m2-community-project bot added the Progress: ready for testing label Apr 9, 2021

magento-engcom-team removed the Component: Translation label Apr 9, 2021

navarr requested a review from eduard13 July 15, 2021 12:24

eduard13 approved these changes Jul 16, 2021

View reviewed changes

Den4ik approved these changes Jul 16, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Jul 16, 2021

engcom-Charlie self-assigned this Oct 1, 2024

Merge branch '2.4-develop' into patch-4

d0a841b

m2-assistant bot mentioned this pull request Oct 7, 2024

[Issue] Improve JS Translation DataProviderTest #39243

Open

4 tasks

Improve JS Translation DataProviderTest #32689

Are you sure you want to change the base?

Improve JS Translation DataProviderTest #32689

Uh oh!

Conversation

navarr commented Apr 7, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 7, 2021

Uh oh!

navarr commented Apr 7, 2021

Uh oh!

ihor-sviziev commented Apr 8, 2021

Uh oh!

ihor-sviziev commented Apr 8, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navarr commented Apr 8, 2021

Uh oh!

navarr commented Apr 8, 2021

Uh oh!

navarr commented Apr 8, 2021

Uh oh!

ihor-sviziev commented Apr 9, 2021

Uh oh!

magento-engcom-team commented Apr 9, 2021

Uh oh!

ihor-sviziev commented Apr 15, 2021

Uh oh!

ihor-sviziev commented Apr 23, 2021

Uh oh!

Den4ik commented May 5, 2021

Uh oh!

magento-automated-testing bot commented May 5, 2021

Uh oh!

ihor-sviziev commented May 6, 2021

Uh oh!

magento-automated-testing bot commented May 6, 2021

Uh oh!

magento-engcom-team commented Jul 16, 2021

Uh oh!

magento-engcom-team commented Jul 16, 2021

Uh oh!

engcom-Charlie commented Oct 7, 2024

Uh oh!

engcom-Charlie commented Oct 7, 2024

Uh oh!

engcom-Charlie commented Oct 7, 2024

Uh oh!

Uh oh!

navarr commented Apr 7, 2021 •

edited by m2-assistant bot

Loading