[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotification modules #33124

vlmed · 2021-06-02T12:41:56Z

Description (*)

Update README.md file for modules:

Magento_QuoteBundleOptions
Magento_QuoteConfigurableOptions
Magento_QuoteDownloadableLinks
Magento_QuoteGraphQl
Magento_RelatedProductGraphQl
Magento_ReleaseNotification

Fixed Issues (if relevant)

magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…on modules

m2-assistant · 2021-06-02T12:41:58Z

Hi @vlmed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

vlmed · 2021-06-02T12:44:34Z

@magento run all tests

magento-automated-testing · 2021-06-02T12:44:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-08-27T15:18:20Z

@magento run Integration Tests

magento-automated-testing · 2021-08-27T15:18:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-08-31T10:44:59Z

@magento run Functional Tests B2B, Functional Tests EE

magento-automated-testing · 2021-08-31T10:45:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-08-31T15:55:27Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-08-31T15:55:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-08-31T22:05:58Z

app/code/Magento/QuoteGraphQl/README.md

+- `setPaymentMethodOnCart` mutation - defines which payment method to apply to the cart.
+  [Learn more about setPaymentMethodOnCart mutation](https://devdocs.magento.com/guides/v2.4/graphql/mutations/set-payment-method.html).
+
+- `setGuestEmailOnCart` mutation - assigns email to the quest cart.


Suggested change

- `setGuestEmailOnCart` mutation - assigns email to the quest cart.

- `setGuestEmailOnCart` mutation - assigns email to the guest cart.

BarnyShergold · 2021-08-31T22:08:03Z

app/code/Magento/QuoteGraphQl/README.md

+- `setGuestEmailOnCart` mutation - assigns email to the quest cart.
+  [Learn more about setGuestEmailOnCart mutation](https://devdocs.magento.com/guides/v2.4/graphql/mutations/set-guest-email.html).
+
+- `setPaymentMethodAndPlaceOrder` mutation - sets the cart payment method and converts the cart into an order. This mutation has been deprecated. Use the `setPaymentMethodOnCart` and `placeOrder` mutations instead.


Make the fact this has been deprecated stand out.

Suggested change

- `setPaymentMethodAndPlaceOrder` mutation - sets the cart payment method and converts the cart into an order. This mutation has been deprecated. Use the `setPaymentMethodOnCart` and `placeOrder` mutations instead.

- `setPaymentMethodAndPlaceOrder` mutation - sets the cart payment method and converts the cart into an order. **This mutation has been deprecated**. Use the `setPaymentMethodOnCart` and `placeOrder` mutations instead.

BarnyShergold · 2021-08-31T22:11:05Z

app/code/Magento/QuoteBundleOptions/README.md

+
+## Extensibility
+
+Extension developers can interact with the Magento_QuoteBundleOptions module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).


Question - on DevDocs & Knowledge Base use of "Magento" is being switched to "Adobe Commerce" - should we not be doing this on these new README.md now, rather than later?

I think we should leave a Magento as in the Readme template https://github.com/magento/devdocs/wiki/Magento-module-README.md provided by Magento.

BarnyShergold · 2021-09-01T09:14:00Z

@vlmed - All tests now pass on this PR, however there are a few small corrections and a question for clarification

BarnyShergold · 2021-09-02T12:55:31Z

@magento run Functional Tests CE

magento-automated-testing · 2021-09-02T12:55:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-09-02T16:09:55Z

@magento run Functional Tests CE

magento-automated-testing · 2021-09-02T16:10:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold · 2021-09-03T12:19:27Z

@magento run Functional Tests CE

magento-automated-testing · 2021-09-03T12:19:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

BarnyShergold

All tests now pass!

magento-engcom-team · 2021-09-03T16:38:33Z

Hi @BarnyShergold, thank you for the review.
ENGCOM-9211 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Hotel · 2021-09-06T08:38:21Z

@magento run all tests

magento-automated-testing · 2021-09-06T08:38:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-09-06T10:30:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Hotel · 2021-09-06T10:33:06Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-09-06T10:33:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Hotel · 2021-09-06T13:03:43Z

✔️ QA Passed

The PR request has updates related to the README.md file content only.

No other manual testing is required and there is no impact on regression testing.

…aseNotification modules #33124

m2-assistant · 2021-09-23T15:54:47Z

Hi @vlmed, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotificati…

ff21e6d

…on modules

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 3, 2021

m2-community-project bot added the Progress: pending review label Jun 3, 2021

BarnyShergold self-assigned this Aug 27, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Aug 27, 2021

BarnyShergold requested changes Aug 31, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Aug 31, 2021

Improve PR

52c72cd

m2-community-project bot removed the Progress: needs update label Sep 1, 2021

BarnyShergold approved these changes Sep 3, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Sep 3, 2021

engcom-Hotel self-assigned this Sep 6, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Sep 6, 2021

BarnyShergold added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 6, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Sep 6, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Sep 6, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Sep 6, 2021

sidolov mentioned this pull request Sep 23, 2021

Fix for admin shipment, creditmemo, invoice pdf emulation #4451

Closed

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2021

ENGCOM-9211: [ReadMe] updated readMe file for QuoteBundleOptions-Rele…

cc11f1c

…aseNotification modules #33124

magento-engcom-team merged commit 1792378 into magento:2.4-develop Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotification modules #33124

[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotification modules #33124

vlmed commented Jun 2, 2021

m2-assistant bot commented Jun 2, 2021

vlmed commented Jun 2, 2021

magento-automated-testing bot commented Jun 2, 2021

BarnyShergold commented Aug 27, 2021

magento-automated-testing bot commented Aug 27, 2021

BarnyShergold commented Aug 31, 2021

magento-automated-testing bot commented Aug 31, 2021

BarnyShergold commented Aug 31, 2021

magento-automated-testing bot commented Aug 31, 2021

BarnyShergold Aug 31, 2021

vlmed Sep 1, 2021

BarnyShergold Aug 31, 2021

vlmed Sep 1, 2021

BarnyShergold Aug 31, 2021

vlmed Sep 1, 2021

BarnyShergold Sep 2, 2021

BarnyShergold commented Sep 1, 2021

BarnyShergold commented Sep 2, 2021

magento-automated-testing bot commented Sep 2, 2021

BarnyShergold commented Sep 2, 2021

magento-automated-testing bot commented Sep 2, 2021

BarnyShergold commented Sep 3, 2021

magento-automated-testing bot commented Sep 3, 2021

BarnyShergold left a comment

magento-engcom-team commented Sep 3, 2021

engcom-Hotel commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

engcom-Hotel commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

engcom-Hotel commented Sep 6, 2021

m2-assistant bot commented Sep 23, 2021

	- `setGuestEmailOnCart` mutation - assigns email to the quest cart.
	- `setGuestEmailOnCart` mutation - assigns email to the guest cart.

	- `setPaymentMethodAndPlaceOrder` mutation - sets the cart payment method and converts the cart into an order. This mutation has been deprecated. Use the `setPaymentMethodOnCart` and `placeOrder` mutations instead.
	- `setPaymentMethodAndPlaceOrder` mutation - sets the cart payment method and converts the cart into an order. This mutation has been deprecated. Use the `setPaymentMethodOnCart` and `placeOrder` mutations instead.


		## Extensibility

		Extension developers can interact with the Magento_QuoteBundleOptions module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).

[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotification modules #33124

[ReadMe] updated readMe file for QuoteBundleOptions-ReleaseNotification modules #33124

Conversation

vlmed commented Jun 2, 2021

Description (*)

Fixed Issues (if relevant)

Contribution checklist (*)

m2-assistant bot commented Jun 2, 2021

vlmed commented Jun 2, 2021

magento-automated-testing bot commented Jun 2, 2021

BarnyShergold commented Aug 27, 2021

magento-automated-testing bot commented Aug 27, 2021

BarnyShergold commented Aug 31, 2021

magento-automated-testing bot commented Aug 31, 2021

BarnyShergold commented Aug 31, 2021

magento-automated-testing bot commented Aug 31, 2021

BarnyShergold Aug 31, 2021

Choose a reason for hiding this comment

vlmed Sep 1, 2021

Choose a reason for hiding this comment

BarnyShergold Aug 31, 2021

Choose a reason for hiding this comment

vlmed Sep 1, 2021

Choose a reason for hiding this comment

BarnyShergold Aug 31, 2021

Choose a reason for hiding this comment

vlmed Sep 1, 2021

Choose a reason for hiding this comment

BarnyShergold Sep 2, 2021

Choose a reason for hiding this comment

BarnyShergold commented Sep 1, 2021

BarnyShergold commented Sep 2, 2021

magento-automated-testing bot commented Sep 2, 2021

BarnyShergold commented Sep 2, 2021

magento-automated-testing bot commented Sep 2, 2021

BarnyShergold commented Sep 3, 2021

magento-automated-testing bot commented Sep 3, 2021

BarnyShergold left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Sep 3, 2021

engcom-Hotel commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

engcom-Hotel commented Sep 6, 2021

magento-automated-testing bot commented Sep 6, 2021

engcom-Hotel commented Sep 6, 2021

m2-assistant bot commented Sep 23, 2021