Skip to content

Fix overlap customer address edit text #33368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 28, 2021

Description (*)

Fix overlap text when left title become long text!
Before (failed at long text)
long-text

After
after

after2

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Backend > Customers > Cannot edit an address when French language is selected #33357

Manual testing scenarios (*)

  1. Go login to backend
  2. Switch to locale with long expected text (ex: france) OR change translate english text length (Default billing address)
  3. Go to customer
  4. Edit addresses
  5. See text visual Default shipping and Default billing address

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 28, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the fix-overlap-customer-address-edit-text branch from 01d3a4b to a1a7dd2 Compare June 28, 2021 14:20
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved
Looks good for me.
@mrtuvn Thanks for contribution

@Den4ik
Copy link
Contributor

Den4ik commented Jun 29, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Customer labels Jun 29, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Jun 30, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9135 has been created to process this Pull Request

@eduard13
Copy link
Contributor

eduard13 commented Jul 7, 2021

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 13, 2021
@engcom-Charlie engcom-Charlie self-assigned this Jul 15, 2021
@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Set admin Language to French from Admin Settings >> Interface Locale

Manual testing scenario:

  1. Go to admin Customers >> All customers >> Select customer(Edit) >> Addresses
  2. Verify the default shipping address & Billing address, observed the Edit link should not overlapped

Actual Result: ✔️

  1. Verified that Edit links are not overlapped with Default shipping address & Default Billing address text in French language and even if the text is longer.

After: ✔️

image

image

Before: ✖️

image

Admin Language setting:

image

Tested all the manual scenarios, no impact on regression testing.

@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend > Customers > Cannot edit an address when French language is selected
6 participants