update getNextAutoincrement #33433

jonashrem · 2021-07-06T17:20:04Z

Description (*)

update getNextAutoincrement to not use showTableStatus for performants reasons. See also #28516

Related Pull Requests

#28516

Fixed Issues (if relevant)

/

Manual testing scenarios (*)

Use Import/Export

Questions or comments

/

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

update getNextAutoincrement to not use showTableStatus for performants reasons. See also magento#28516

m2-assistant · 2021-07-06T17:20:07Z

Hi @jonashrem. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

jonashrem · 2021-07-06T20:38:22Z

@magento run all tests

magento-automated-testing · 2021-07-06T20:38:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-07-07T06:48:44Z

@jonashrem, good catch! Do you have some performance measurements?

app/code/Magento/ImportExport/Model/ResourceModel/Helper.php

engcom-Alfa · 2021-11-03T14:21:04Z

Hi @jonashrem Thanks for your contribution!
This PR has no details about the issue at all. Kindly provide me the below details in order to process it please.

Issue summary
Detailed description about the issue
Detailed steps to reproduce the issue
Expected result
Actual result
Any additional information if you can provide along with screenshots as such please

Thanks in advance!

…o patch-5

engcom-Lima · 2022-01-04T11:21:35Z

@magento run all tests

magento-automated-testing · 2022-01-04T11:21:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-01-04T11:45:39Z

Hi @ihor-sviziev, I have updated the code, moving it to Pending Review column for code review

ihor-sviziev · 2022-01-05T10:29:16Z

@magento run all tests

magento-automated-testing · 2022-01-05T10:29:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-01-12T08:15:36Z

@magento run all tests

magento-automated-testing · 2022-01-12T08:15:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

Hi @jonashrem @engcom-Lima,
Could you review and fix the test failures?

magento-automated-testing · 2022-10-20T18:02:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-27T12:35:26Z

@magento run all tests

magento-automated-testing · 2023-01-27T12:35:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-31T06:02:00Z

@magento run all tests

magento-automated-testing · 2023-01-31T06:02:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-02-01T11:42:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-01T12:10:57Z

@magento run all tests

magento-automated-testing · 2023-02-01T12:11:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-02T05:47:56Z

@magento run all tests

magento-automated-testing · 2023-02-02T05:48:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-06T06:43:49Z

@magento run all tests

magento-automated-testing · 2023-02-06T06:43:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-02-06T09:05:45Z

@magento run Functional Tests B2B,Functional Tests CE,Unit Tests

magento-automated-testing · 2023-02-06T09:05:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

glo17680 · 2023-02-13T09:51:01Z

@magento run Database Compare, Integration Tests

magento-automated-testing · 2023-02-13T09:51:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

glo17680 · 2023-02-14T07:20:08Z

@magento run all tests

magento-automated-testing · 2023-02-14T07:20:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2024-11-13T11:20:23Z

Hi @jonashrem,
Is this fix still actual for Mysql 8?
I checked locally, got approximately the same numbers
BTW, for MySQL 8, there is additional query is ran:

magento2/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

Lines 1313 to 1318 in 651928c

    
           // Run show table status query in different connection because DDL queries do it in transaction, 
        
           // and we don't have actual table statistic in this case 
        
           $connection = $this->_transactionLevel ? $this->createConnection() : $this; 
        
           $connection->query(sprintf('ANALYZE TABLE %s', $this->quoteIdentifier($tableName))); 
        
           return $connection->query($query)->fetch(\PDO::FETCH_ASSOC);

update getNextAutoincrement

66696e6

update getNextAutoincrement to not use showTableStatus for performants reasons. See also magento#28516

removed unused parameter inside getNextAutoincrement

fba3c85

This was referenced Jul 6, 2021

Update getNextAutoincrement to not use showTableStatus OpenMage/magento-lts#1721

Closed

backport showTableStatus from Magento2 OpenMage/magento-lts#1712

Closed

ihor-sviziev requested changes Jul 7, 2021

View reviewed changes

app/code/Magento/ImportExport/Model/ResourceModel/Helper.php Outdated Show resolved Hide resolved

m2-community-project bot assigned ihor-sviziev Jul 7, 2021

m2-community-project bot added the Progress: needs update label Jul 7, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 7, 2021

sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 4, 2021

engcom-Lima self-assigned this Jan 3, 2022

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

acb5080

…o patch-5

[BUGFIX] - Corrected breaking code

7e13fe7

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Jan 4, 2022

ihor-sviziev requested changes Jan 13, 2022

View reviewed changes

m2-community-project bot added Progress: pending review Progress: needs update and removed Progress: needs update Progress: pending review labels Dec 8, 2022

Merge branch '2.4-develop' into patch-5

f2fb780

Merge branch '2.4-develop' into patch-5

3b0381c

engcom-Echo self-assigned this Feb 1, 2023

Merge branch '2.4-develop' into patch-5

16bc249

Merge branch '2.4-develop' into patch-5

abbf247

engcom-Echo removed their assignment Feb 8, 2023

Merge branch '2.4-develop' into patch-5

a2ef34e

update getNextAutoincrement #33433

Are you sure you want to change the base?

update getNextAutoincrement #33433

Uh oh!

Conversation

jonashrem commented Jul 6, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 6, 2021

Uh oh!

jonashrem commented Jul 6, 2021

Uh oh!

magento-automated-testing bot commented Jul 6, 2021

Uh oh!

ihor-sviziev commented Jul 7, 2021

Uh oh!

Uh oh!

engcom-Alfa commented Nov 3, 2021

Uh oh!

engcom-Lima commented Jan 4, 2022

Uh oh!

magento-automated-testing bot commented Jan 4, 2022

Uh oh!

engcom-Lima commented Jan 4, 2022

Uh oh!

ihor-sviziev commented Jan 5, 2022

Uh oh!

magento-automated-testing bot commented Jan 5, 2022

Uh oh!

ihor-sviziev commented Jan 12, 2022

Uh oh!

magento-automated-testing bot commented Jan 12, 2022

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Oct 20, 2022

Uh oh!

engcom-Echo commented Jan 27, 2023

Uh oh!

magento-automated-testing bot commented Jan 27, 2023

Uh oh!

engcom-Echo commented Jan 31, 2023

Uh oh!

magento-automated-testing bot commented Jan 31, 2023

Uh oh!

magento-automated-testing bot commented Feb 1, 2023

Uh oh!

engcom-Echo commented Feb 1, 2023

Uh oh!

magento-automated-testing bot commented Feb 1, 2023

Uh oh!

engcom-Echo commented Feb 2, 2023

Uh oh!

magento-automated-testing bot commented Feb 2, 2023

Uh oh!

engcom-Echo commented Feb 6, 2023

Uh oh!

magento-automated-testing bot commented Feb 6, 2023

Uh oh!

engcom-Echo commented Feb 6, 2023

Uh oh!

magento-automated-testing bot commented Feb 6, 2023

Uh oh!

glo17680 commented Feb 13, 2023

Uh oh!

magento-automated-testing bot commented Feb 13, 2023

Uh oh!

glo17680 commented Feb 14, 2023

Uh oh!

magento-automated-testing bot commented Feb 14, 2023

Uh oh!

ihor-sviziev commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Nov 13, 2024 •

edited

Loading