Inheriting from a class that doesn't exist#33334 #33449

monteshot · 2021-07-09T13:54:50Z

Changed PRICE_CODE constant from non-exist class to $this class
This class already have its own constant on 28 line.
const PRICE_CODE = self::CONFIGURED_PRICE_CODE;
The related issue Inheriting from a class that doesn't exist #33334

Description (*)

The class that responsible for getting price value uses not valid constant.
I was remove incorrect constant and add the constant from this class that can be correctly overrided.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Inheriting from a class that doesn't exist #33334

Manual testing scenarios (*)

On any properly created bundle product will be executed \Magento\Catalog\Pricing\Render\ConfiguredPriceBox because the
\Magento\Catalog\Pricing\Price\ConfiguredPriceInterface::CONFIGURED_PRICE_CODE is in Magento\Bundle\Pricing\Price\Pool
The render mechanism will found the template app/code/Magento/Catalog/view/base/templates/product/price/configured_price.phtml that will get the class \Magento\Bundle\Pricing\Price\ConfiguredRegularPrice that inherits from \Magento\Bundle\Pricing\Price\ConfiguredPrice with the problem get value method
On line 18 of app/code/Magento/Catalog/view/base/templates/product/price/configured_price.phtml will be invoked code from \Magento\Bundle\Pricing\Price\ConfiguredPrice::getValue
If item was previously set using setItem the getValue code will throw exception
I change to self::PRICE_CODE and code no longer crash

Questions or comments

Comments:
The class that inherits this class already have the Unit test
\Magento\Catalog\Test\Unit\Pricing\Price\ConfiguredPriceTest but it.
Also i wrote unit for getValue method

Normally on frontend the code with error not invokes. It seems to be fallback.
This code may crash when unit tests executing

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

- Changed PRICE_CODE constant from non-exist class to $this class

- calculateDiscount method must be point as FinalPrice to its class but in ConfiguredPrice.php this method not exist. Also in FinalPrice invokes the \Magento\Bundle\Pricing\Price\DiscountCalculator::calculateDiscount - added unit test for method getValue

m2-assistant · 2021-07-09T13:54:52Z

Hi @monteshot. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

monteshot · 2021-07-09T13:55:36Z

@magento run all tests

magento-automated-testing · 2021-07-09T13:55:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

app/code/Magento/Bundle/Pricing/Price/ConfiguredPrice.php

- Removed unnecessary nesting in if statements according to the interface

…sn't_exist#33334' into Inheriting_from_a_class_that_doesn't_exist#33334

monteshot · 2021-07-12T06:31:09Z

Hello.
What should i do with this semantic error @bgorski

Thanks.

monteshot · 2021-07-12T06:34:35Z

Neither module.xml nor composer.json i cannot change version because its absent in both files

- Removed unnecessary properties from test class

monteshot · 2021-07-12T06:43:33Z

@magento run all tests

magento-automated-testing · 2021-07-12T06:43:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

- Update the unit test for getter in case non-existing the item

monteshot · 2021-07-12T12:45:14Z

@magento run all tests

magento-automated-testing · 2021-07-12T12:45:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

- Made changes backwards compatible.

monteshot · 2021-07-12T14:07:52Z

@magento run all tests

magento-engcom-team · 2021-07-25T02:06:55Z

Hi @bgorski, thank you for the review.
ENGCOM-9161 has been created to process this Pull Request

magento-engcom-team · 2021-07-27T04:21:51Z

Hi @Den4ik, thank you for the review.
ENGCOM-9161 has been created to process this Pull Request

engcom-Hotel · 2021-09-02T10:44:23Z

@magento run all tests

magento-automated-testing · 2021-09-02T10:44:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

monteshot · 2021-09-02T13:06:44Z

Another flaky test failed
@engcom-Hotel I will restart tests

monteshot · 2021-09-02T13:07:32Z

@magento run Functional Tests EE

magento-automated-testing · 2021-09-02T13:07:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Hotel · 2021-09-06T08:00:56Z

✔️ QA Passed

Hello @monteshot,

I have tested this fix by setting items previously using the setItem method. Below is the before and after fix screenshot:

Before ✖️

After ✔️

Verified that the below fatal error should not come:

Error : Class 'Magento\Bundle\Pricing\Price\BundleDiscountPrice' not found

Tested all the manual scenarios, no impact on regression testing.

Thanks

m2-assistant · 2021-09-23T15:54:44Z

Hi @monteshot, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

monteshot added 2 commits July 9, 2021 11:39

magento#33334:Inheriting from a class that doesn't exist

f649582

- Changed PRICE_CODE constant from non-exist class to $this class

m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review labels Jul 9, 2021

bgorski self-requested a review July 10, 2021 11:08

bgorski self-assigned this Jul 10, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 10, 2021

bgorski requested changes Jul 10, 2021

View reviewed changes

app/code/Magento/Bundle/Pricing/Price/ConfiguredPrice.php Outdated Show resolved Hide resolved

m2-community-project bot added Progress: needs update Progress: review and removed Progress: review Progress: needs update labels Jul 10, 2021

monteshot requested a review from bgorski July 10, 2021 13:03

monteshot added 3 commits July 12, 2021 09:19

Removed unnecessary nesting in if statements according to the interface

3a92f3e

magento#33334:Inheriting from a class that doesn't exist

c717b34

- Removed unnecessary nesting in if statements according to the interface

Merge remote-tracking branch 'origin/Inheriting_from_a_class_that_doe…

995cb2a

…sn't_exist#33334' into Inheriting_from_a_class_that_doesn't_exist#33334

magento#33334:Inheriting from a class that doesn't exist

b0c2133

- Removed unnecessary properties from test class

magento#33334:Inheriting from a class that doesn't exist

1aa93e0

- Update the unit test for getter in case non-existing the item

magento#33334:Inheriting from a class that doesn't exist

33914c1

- Made changes backwards compatible.

Den4ik self-assigned this Jul 27, 2021

Den4ik approved these changes Jul 27, 2021

View reviewed changes

engcom-Charlie assigned engcom-Charlie and unassigned engcom-Charlie Jul 28, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 5, 2021

engcom-Hotel self-assigned this Aug 5, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: testing in progress Progress: ready for testing labels Aug 5, 2021

bgorski added the Award: bug fix label Aug 25, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: testing in progress Progress: ready for testing labels Aug 25, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Sep 6, 2021

sidolov mentioned this pull request Sep 23, 2021

Inheriting from a class that doesn't exist #33334

Closed

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2021

ENGCOM-9161: Inheriting from a class that doesn't exist#33334 #33449

8300ada

magento-engcom-team merged commit 7843399 into magento:2.4-develop Sep 23, 2021

Inheriting from a class that doesn't exist#33334 #33449

Inheriting from a class that doesn't exist#33334 #33449

Uh oh!

Conversation

monteshot commented Jul 9, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 9, 2021

Uh oh!

monteshot commented Jul 9, 2021

Uh oh!

magento-automated-testing bot commented Jul 9, 2021

Uh oh!

Uh oh!

monteshot commented Jul 12, 2021

Uh oh!

monteshot commented Jul 12, 2021

Uh oh!

monteshot commented Jul 12, 2021

Uh oh!

magento-automated-testing bot commented Jul 12, 2021

Uh oh!

monteshot commented Jul 12, 2021

Uh oh!

magento-automated-testing bot commented Jul 12, 2021

Uh oh!

monteshot commented Jul 12, 2021

Uh oh!

magento-engcom-team commented Jul 25, 2021

Uh oh!

magento-engcom-team commented Jul 27, 2021

Uh oh!

engcom-Hotel commented Sep 2, 2021

Uh oh!

magento-automated-testing bot commented Sep 2, 2021

Uh oh!

monteshot commented Sep 2, 2021

Uh oh!

monteshot commented Sep 2, 2021

Uh oh!

magento-automated-testing bot commented Sep 2, 2021

Uh oh!

engcom-Hotel commented Sep 6, 2021

Uh oh!

m2-assistant bot commented Sep 23, 2021

Uh oh!

Uh oh!