33589 fix array values in catalogsearch parameters #33682

SilinMykola · 2021-08-04T11:24:13Z

Description (*)

I changed a method that prepare values for advanced search. Model: \Magento\CatalogSearch\Model\Advanced

Fixed Issues (if relevant)

Fixes strlen() expects parameter 1 to be string, array given | magento/module-catalog-search #33589

Manual testing scenarios (*)

Open page with parameters: /catalogsearch/advanced/result/?price[from][]=1&price[to]=1
For example: htps://base_url/catalogsearch/advanced/result/?price[from][]=1&price[to]=1

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-08-04T11:24:17Z

Hi @SilinMykola. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

SilinMykola · 2021-08-04T11:26:07Z

@magento run all tests

magento-automated-testing · 2021-08-04T11:26:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-05T04:15:04Z

@magento give me test instance

magento-deployment-service · 2021-08-05T04:15:07Z

Hi @andrewbess. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-08-05T04:16:24Z

Hi @andrewbess, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

eduard13

Hi @SilinMykola, could you please cover these changes by an integration test?

Thank you.

andrewbess · 2021-08-05T06:16:09Z

@magento give me test instance

magento-deployment-service · 2021-08-05T06:16:12Z

Hi @andrewbess. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-08-05T06:21:24Z

Hi @andrewbess, here is your Magento Instance: https://a3fe9860c4997848dc40cb217d7c0332.instances.magento-community.engineering
Admin access: https://a3fe9860c4997848dc40cb217d7c0332.instances.magento-community.engineering/admin_05dc
Login: 0252dc90
Password: 1d9c8a96fc28

andrewbess · 2021-08-05T06:27:18Z

@magento run all tests

magento-automated-testing · 2021-08-05T06:27:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

SilinMykola · 2021-08-05T08:35:17Z

Hi @SilinMykola, could you please cover these changes by an integration test?

Thank you.

Hi! @eduard13 ! Ok, I'll create integration test for this model.

eduard13 · 2021-08-05T08:37:10Z

@SilinMykola, additionally, could you please check how the catalogsearch/result handles such cases?
Thanks.

ihor-sviziev · 2021-08-05T18:43:41Z

app/code/Magento/CatalogSearch/Model/Advanced.php

+                    if (is_array($value['from'])) {
+                        $value['from'] = $this->getFirstArrayElement($value['from']);
+                    }
+                    if (is_array($value['to'])) {
+                        $value['to'] = $this->getFirstArrayElement($value['to']);
+                    }


I think, in case if we got an incorrect type - it's better to do assume that this parameter doesn't exist at all. I think we're expecting here the only string.

@ihor-sviziev Hi! May be you are right and we should create a redirect if $value['from'] or $value['to'] is array. But I think we can check this arrays for some values and create a valid response.

cc: @andrewbess, @eduard13

@SilinMykola I'm agree with @ihor-sviziev that we should ignore this parameter if it's not valid instead of trying to understand what we received and extract some data from it.
Looks like patch for all occasions.

Ok, @Den4ik! Locally I removed this code and work on tests.

The following comment is related to this discussion #33589 (comment)

magento-automated-testing · 2021-08-23T15:45:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-08-24T09:12:34Z

@SilinMykola Please check failed integration tests

SilinMykola · 2021-08-24T18:13:23Z

@magento run all tests

magento-automated-testing · 2021-08-24T18:13:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

SilinMykola · 2021-08-24T21:31:57Z

@magento run Functional Tests EE

magento-automated-testing · 2021-08-24T21:32:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-25T06:28:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

After discussion with @SilinMykola in slack and test possible one another solution I approve this PR as easiest an fast solution for now.
@SilinMykola Thanks for the work

magento-engcom-team · 2021-08-25T10:05:35Z

Hi @Den4ik, thank you for the review.
ENGCOM-9197 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2021-08-25T10:15:25Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9197 has been created to process this Pull Request

engcom-Alfa · 2021-09-01T13:01:19Z

✔️ QA Passed

Preconditions:

Install fresh Magento instance with sample data.

Manual testing scenario:

Front end: Click on "advanced search" link from the footer.
Set the price 1 to 1 and do search
Edit the resulted URL from /***/advanced/result/?name=&sku=&description=&short_description=&price%5Bfrom%5D=1&price%5Bto%5D=1 to /***/advanced/result/?price[from][]=1&price[to]=1
Validate the edited URL response in the web page.

Before: ✖️ Used to get an error message

After: ✔️ Gives the search result information

With no result data

With result data

There is no additional regression is required since it is a specific case where we are doing an URL tampering. It has no impact on any other features as well.

m2-assistant · 2021-09-23T15:54:41Z

Hi @SilinMykola, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

33589 fix array values in catalogsearch parameters

58adfbf

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 4, 2021

magento-engcom-team added Component: CatalogSearch Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 4, 2021

m2-community-project bot added the Progress: pending review label Aug 4, 2021

andrewbess assigned eduard13 and andrewbess Aug 4, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Aug 4, 2021

Merge branch '2.4-develop' into 33589-catalogsearch-strlen-exception

0c72905

eduard13 requested changes Aug 5, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Aug 5, 2021

ihor-sviziev requested changes Aug 5, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Aug 5, 2021

33589 fix integration test

44ed899

SilinMykola requested review from eduard13, ihor-sviziev and Den4ik August 25, 2021 05:50

Den4ik approved these changes Aug 25, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Aug 25, 2021

magento-engcom-team added the Area: Frontend label Aug 25, 2021

Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 25, 2021

ihor-sviziev approved these changes Aug 25, 2021

View reviewed changes

engcom-Alfa self-assigned this Aug 27, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 27, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Sep 1, 2021

sidolov mentioned this pull request Sep 23, 2021

strlen() expects parameter 1 to be string, array given | magento/module-catalog-search #33589

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2021

ENGCOM-9197: 33589 fix array values in catalogsearch parameters #33682

8992413

magento-engcom-team merged commit 1a71a80 into magento:2.4-develop Sep 23, 2021

SilinMykola deleted the 33589-catalogsearch-strlen-exception branch September 23, 2021 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

33589 fix array values in catalogsearch parameters #33682

33589 fix array values in catalogsearch parameters #33682

SilinMykola commented Aug 4, 2021

m2-assistant bot commented Aug 4, 2021

SilinMykola commented Aug 4, 2021

magento-automated-testing bot commented Aug 4, 2021

andrewbess commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

eduard13 left a comment

andrewbess commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

andrewbess commented Aug 5, 2021

magento-automated-testing bot commented Aug 5, 2021

SilinMykola commented Aug 5, 2021

eduard13 commented Aug 5, 2021

ihor-sviziev Aug 5, 2021

SilinMykola Aug 6, 2021

Den4ik Aug 13, 2021

SilinMykola Aug 13, 2021

ihor-sviziev Aug 16, 2021

magento-automated-testing bot commented Aug 23, 2021

Den4ik commented Aug 24, 2021

SilinMykola commented Aug 24, 2021

magento-automated-testing bot commented Aug 24, 2021

SilinMykola commented Aug 24, 2021

magento-automated-testing bot commented Aug 24, 2021

magento-automated-testing bot commented Aug 25, 2021

Den4ik left a comment

magento-engcom-team commented Aug 25, 2021

magento-engcom-team commented Aug 25, 2021

engcom-Alfa commented Sep 1, 2021

m2-assistant bot commented Sep 23, 2021

33589 fix array values in catalogsearch parameters #33682

33589 fix array values in catalogsearch parameters #33682

Conversation

SilinMykola commented Aug 4, 2021

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Aug 4, 2021

SilinMykola commented Aug 4, 2021

magento-automated-testing bot commented Aug 4, 2021

andrewbess commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

eduard13 left a comment

Choose a reason for hiding this comment

andrewbess commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

magento-deployment-service bot commented Aug 5, 2021

andrewbess commented Aug 5, 2021

magento-automated-testing bot commented Aug 5, 2021

SilinMykola commented Aug 5, 2021

eduard13 commented Aug 5, 2021

ihor-sviziev Aug 5, 2021

Choose a reason for hiding this comment

SilinMykola Aug 6, 2021

Choose a reason for hiding this comment

Den4ik Aug 13, 2021

Choose a reason for hiding this comment

SilinMykola Aug 13, 2021

Choose a reason for hiding this comment

ihor-sviziev Aug 16, 2021

Choose a reason for hiding this comment

magento-automated-testing bot commented Aug 23, 2021

Den4ik commented Aug 24, 2021

SilinMykola commented Aug 24, 2021

magento-automated-testing bot commented Aug 24, 2021

SilinMykola commented Aug 24, 2021

magento-automated-testing bot commented Aug 24, 2021

magento-automated-testing bot commented Aug 25, 2021

Den4ik left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Aug 25, 2021

magento-engcom-team commented Aug 25, 2021

engcom-Alfa commented Sep 1, 2021

m2-assistant bot commented Sep 23, 2021