Skip to content

Added "Today" to dashboard report #33874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

NetStorm84
Copy link
Contributor

@NetStorm84 NetStorm84 commented Aug 20, 2021

Description (*)

Adds "Today" to the dashboard charts, so we can get a summary of sales/orders throughout the day.

image

Manual testing scenarios (*)

  1. Checkout an order as a customer
  2. Log in to the backend
  3. Enable Charts
  4. Select "Today" From either the Orders or Amounts tab on the dashboard
  5. Check the Graph and figures update accordingly

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Added "Today" to dashboard report #34008: Added "Today" to dashboard report

@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2021

Hi @NetStorm84. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@NetStorm84
Copy link
Contributor Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @NetStorm84. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@NetStorm84
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@NetStorm84
Copy link
Contributor Author

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@NetStorm84
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@NetStorm84
Copy link
Contributor Author

Not sure why the Functional Tests are failing, seems unrelated to my PR?

@NetStorm84
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea and looks great too :)

@magento-engcom-team
Copy link
Contributor

Hi @BarnyShergold, thank you for the review.
ENGCOM-9194 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@BarnyShergold BarnyShergold added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 24, 2021
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9194 has been created to process this Pull Request

@NetStorm84
Copy link
Contributor Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @NetStorm84. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @NetStorm84, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@BarnyShergold BarnyShergold added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 7, 2021
@engcom-Alfa engcom-Alfa self-assigned this Sep 7, 2021
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have a Magento instance installed with sample data or by storing some data

Manual testing scenario:

  1. Create a new customer and place a new order from the front end.

  2. Login to admin and enable the chart from admin configurations

  3. View Dashboard page and validate the Orders/Amounts section dropdown content.

Before: ✖️ "Today" option was not included in the dropdown.

image

After: ✔️ "Today" option is included in the dropdown.

image

Additionally checked the graph data is getting reloaded according the dropdown option we select. There is no other issue noticed and no regression is required since it has no impact on any other feature.

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2021

Hi @NetStorm84, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ccondra
Copy link

ccondra commented Jan 19, 2022

Documentation update for this feature:
#34008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Backend Component: Reports Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Added "Today" to dashboard report
6 participants