-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added "Today" to dashboard report #33874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Today" to dashboard report #33874
Conversation
Hi @NetStorm84. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me test instance |
Hi @NetStorm84. Thank you for your request. I'm working on Magento instance for you. |
Hi @NetStorm84, here is your Magento Instance: https://fe45f841d3a92744ee9ba7273bb5c840.instances.magento-community.engineering |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Not sure why the Functional Tests are failing, seems unrelated to my PR? |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea and looks great too :)
Hi @BarnyShergold, thank you for the review.
|
Hi @Den4ik, thank you for the review. |
@magento give me test instance |
Hi @NetStorm84. Thank you for your request. I'm working on Magento instance for you. |
Hi @NetStorm84, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
@magento create issue |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ "Today" option was not included in the dropdown. After: ✔️ "Today" option is included in the dropdown. Additionally checked the graph data is getting reloaded according the dropdown option we select. There is no other issue noticed and no regression is required since it has no impact on any other feature. |
Hi @NetStorm84, thank you for your contribution! |
Documentation update for this feature: |
Description (*)
Adds "Today" to the dashboard charts, so we can get a summary of sales/orders throughout the day.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: