-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add regions for Belarus #33922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regions for Belarus #33922
Conversation
Hi @DmitryFurs. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Database Compare |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
app/code/Magento/Directory/Setup/Patch/Data/AddDataForBelarus.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitryFurs thanks for the PR and all the fixes you made on it! Looks great, clicking Approve now.
Hi @shikhamis11, here is your Magento Instance: https://1e65b12daf40a7cb0f7a2893be0ef7d9.instances.magento-community.engineering |
@bgorski @shikhamis11 it may be worth moving the item Horad Minsk to the beginning or end of the list so that the options are grouped more correctly. What do you think? |
no, I don’t think It is required. It's more important to have it in alphabetical order from (A to Z) |
@magento run Integration Tests, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @shikhamis11, thank you for the review.
|
Hi @Den4ik, thank you for the review. |
Hi @DmitryFurs, thank you for your contribution! |
Description
Add regions for Belarus
Manual testing scenarios
Questions or comments
Contribution checklist
Resolved issues: