Skip to content

Add regions for Belarus #33922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

DmitryFurs
Copy link
Contributor

@DmitryFurs DmitryFurs commented Aug 26, 2021

Description

Add regions for Belarus

Manual testing scenarios

  1. Install Magento
  2. Check table directory_country_region for Belarus regions.

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add regions for Belarus #33924: Add regions for Belarus

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2021

Hi @DmitryFurs. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@shikhamis11
Copy link
Member

@magento create issue

@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@shikhamis11 shikhamis11 added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 26, 2021
@bgorski
Copy link
Contributor

bgorski commented Aug 27, 2021

@magento run Database Compare

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link
Contributor

@bgorski bgorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitryFurs thanks for the PR and all the fixes you made on it! Looks great, clicking Approve now.

@magento-deployment-service
Copy link

@DmitryFurs
Copy link
Contributor Author

@bgorski @shikhamis11 it may be worth moving the item Horad Minsk to the beginning or end of the list so that the options are grouped more correctly. What do you think?

image

@shikhamis11
Copy link
Member

@bgorski @shikhamis11 it may be worth moving the item Horad Minsk to the beginning or end of the list so that the options are grouped more correctly. What do you think?

image

no, I don’t think It is required. It's more important to have it in alphabetical order from (A to Z)

@shikhamis11
Copy link
Member

@magento run Integration Tests, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, thank you for the review.
ENGCOM-9204 has been created to process this Pull Request
✳️ @shikhamis11, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Should have latest Magento installed.

Manual testing scenario:

  1. Login to the front end and navigate to My account - add/ edit address; Select country Belarus and followed by try to select states belonging to Belarus.

  2. Login as admin and navigate to Store> Configuration> Store Information; Select country Belarus and followed by try to select states belonging to Belarus.

Before: ✖️ State names were not displaying belonging to the Belarus country
image

After: ✔️ State names of Belarus country are getting displayed in the state dropdown options appropriately
image

There is no additional testing/ regression is required since it is relevant to updating an state names belonging to one country.

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9204 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2021

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Directory Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add regions for Belarus
6 participants