-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix values select elements (example addresses customer prefix) #35055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Fix values select elements (example addresses customer prefix) #35055
Conversation
Hi @mickaelBaillotPh2m. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
You changes look clean and reasonable! Can you add some automation tests cover changes |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
If this is your first time contributions please sign CLA and high recommended take a looks at guidelines |
@@ -134,7 +134,7 @@ private function convertElementsToSelect($elements, $attributesToConvert) | |||
|
|||
foreach ($options as $key => $value) { | |||
$elements[$code]['options'][] = [ | |||
'value' => $key, | |||
'value' => $value, | |||
'label' => $value, | |||
]; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can ommit/remove $key here right as
in foreach
@magento give me 2.4.3 instance |
Hi @marciomaciel. Thank you for your request. I'm working on Magento instance for you. |
Hi @marciomaciel, here is your Magento Instance: https://285b12735eb570c9d6c4d6980a02ea60.instances.magento-community.engineering |
Description (*)
In Magento 2.4.2 Addresse customers prefix are displayed as numbers
Mr => 1
Mrs => 2
NULL => 0
So if I created an address with
Mr Lastname Firstname
In checkout (FO) and in BO detail order we'll see "1 Lastname Firstname"
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
with this informations :
Questions or comments
Contribution checklist (*)