Skip to content

Fix values select elements (example addresses customer prefix) #35055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

mickaelBaillotPh2m
Copy link

Description (*)

In Magento 2.4.2 Addresse customers prefix are displayed as numbers
Mr => 1
Mrs => 2
NULL => 0

So if I created an address with
Mr Lastname Firstname
In checkout (FO) and in BO detail order we'll see "1 Lastname Firstname"

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Install new 2.4.2 Magento
  2. Create an account and add a new address
    with this informations :
  • Prefix : Mr
  • Lastname : Lastname
  • Firstname : Firstname
  1. Add a product in your cart and go to shipping checkout step
  2. You can see "Mr" is replaced by "1"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2022

Hi @mickaelBaillotPh2m. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mickaelBaillotPh2m
Copy link
Author

image
You can see address create before fix in the left of the screenshot, and after the fix in the right of the screenshot

@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 4, 2022

You changes look clean and reasonable! Can you add some automation tests cover changes
@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 4, 2022

If this is your first time contributions please sign CLA and high recommended take a looks at guidelines

@mrtuvn mrtuvn added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 5, 2022
@@ -134,7 +134,7 @@ private function convertElementsToSelect($elements, $attributesToConvert)

foreach ($options as $key => $value) {
$elements[$code]['options'][] = [
'value' => $key,
'value' => $value,
'label' => $value,
];
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can ommit/remove $key here right as in foreach

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 8, 2022
@marciomaciel
Copy link

@magento give me 2.4.3 instance

@magento-deployment-service
Copy link

Hi @marciomaciel. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Checkout Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4 Type: Code Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants