reference directive restored for _extends.less. extends replaced to mixins in _extend.less #35101

serhii-chernenko · 2022-02-14T15:04:56Z

Description (*)

When I installed a clear M2, I saw that the reference directive removed for the import of _extends.less file. I've found this PR and I explained why removing reference is a bad idea:
#31793 (comment)

I've investigated later how to restore reference but repair the issue of Grunt in the PR.

And I've found a solution described here:
#31793 (comment)

@ihor-sviziev asked me to create a PR with the fix, so I made it.

Related Pull Requests

#31793

Manual testing scenarios (*)

Create a new theme which extends Magento Blank theme.
Compile styles via default deploying (setup:static-content:deploy) and via Grunt.
Look at block titles of My Account (they should look the same after all build processes).
Find matches of abs selectors in styles-m.css and styles-l.css files. Quantity of them and the size of styles-m.css should be less in comparison with the main branch (2.4-develop).

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] reference directive restored for _extends.less. extends replaced to mixins in _extend.less #36914: reference directive restored for _extends.less. extends replaced to mixins in _extend.less

…ixins in _extend.less

m2-assistant · 2022-02-14T15:05:00Z

Hi @iNeViX. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2022-02-14T15:52:21Z

@magento run all tests

magento-automated-testing · 2022-02-14T15:52:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-02-14T19:51:17Z

@mrtuvn, could you please review?

mrtuvn · 2022-02-20T07:19:30Z

Looking goods at my pov
Sorry current i totally lost of track with magento codebase. Since a while i don't work with magento anymore. But i will support you as much as possible
Class mixins, or abstract in reference import should not show at output files final css. I think current extend way seem outdated and not working properly if we use grunt compile. This task may take efforts to recheck with extend implements in codebase. If we want styles consistency same (php compile and lessjs compile/grunt)
From my opinion i think we need to check compare results file extends with both theme luma/blank too

mrtuvn · 2022-02-20T07:22:08Z

Can you check static fails at reports ?

magento-automated-testing · 2022-03-09T05:04:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-03-09T05:07:10Z

@magento run Static Tests

magento-automated-testing · 2022-03-09T05:07:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-03-09T06:13:35Z

Seem false positive results from Less sniffer checks. From my view is magento use php to check less/css code syntax ?
cc: @ihor-sviziev @sidolov

mrtuvn · 2022-06-05T00:12:34Z

@magento run Static Tests

mrtuvn · 2022-06-05T00:12:34Z

@magento run Static Tests

magento-automated-testing · 2022-06-05T00:12:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2022-06-05T00:12:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2022-06-06T00:23:11Z

magento/magento-coding-standard#395
Found this one report may clear for reason fail static tests. I think we should take a look at current implement in static check sniffer
CC: @ihor-sviziev @sdzhepa @sivaschenko

mrtuvn

looks good

magento-automated-testing · 2023-01-05T03:57:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-17T11:03:38Z

@magento run WebAPI Tests,Integration Tests,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2023-01-17T11:03:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-20T10:29:07Z

@iNeViX @mrtuvn @ihor-sviziev
Thanks for the collaboration & contribution!

✔️ QA Passed
reference directive restored for _extends.less. extends replaced to mixins in _extend.less

Manual Scenario Steps
For manual steps we have followed comment

For actual result we have followed comment

Before: ✖️

Theme luma (search/find available ".abs-")
styles-l.css 77

styles-m.css 419

After: ✔️
Theme luma (search/find available ".abs-")
styles-l.css 68

styles-m.css 254

As there are test failure so moving to Extended Testing

engcom-Echo · 2023-01-24T12:06:05Z

@magento run all tests

magento-automated-testing · 2023-01-24T12:06:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-25T10:14:15Z

@magento run Functional Tests B2B ,Functional Tests EE

magento-automated-testing · 2023-01-25T10:14:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-25T13:16:51Z

@magento run Functional Tests B2B ,Functional Tests EE

magento-automated-testing · 2023-01-25T13:16:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-27T03:03:49Z

Functional Tests EE and Functional Tests B2B failures are different on last two run.
Functional Tests EE
Run1

Run2

Functional Tests B2B
Run1

Run2

Hence moving to Merge In Progress

engcom-Lima · 2023-02-23T10:50:02Z

@magento create issue

reference directive restored for _extends.less. extends replaced to m…

3ca077f

…ixins in _extend.less

magento-engcom-team added Area: Design/Frontend Release Line: 2.4 labels Feb 14, 2022

serhii-chernenko closed this Feb 14, 2022

serhii-chernenko reopened this Feb 14, 2022

serhii-chernenko mentioned this pull request Feb 14, 2022

Fix some nested extends have been ignored at output #31793

Merged

4 tasks

ihor-sviziev requested a review from mrtuvn February 14, 2022 20:58

sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Feb 17, 2022

m2-community-project bot added the Progress: pending review label Feb 17, 2022

mrtuvn added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 9, 2022

mrtuvn added the Progress: needs update label Mar 9, 2022

m2-community-project bot removed the Progress: pending review label Mar 9, 2022

ihor-sviziev mentioned this pull request Jun 9, 2022

Expected 1 space after colon with &:not(:first-child) magento/magento-coding-standard#395

Open

mrtuvn approved these changes Jun 10, 2022

View reviewed changes

m2-community-project bot assigned mrtuvn Jun 10, 2022

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Jan 17, 2023

engcom-Echo self-assigned this Jan 17, 2023

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: extended testing Progress: ready for testing labels Jan 17, 2023

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jan 20, 2023

Fixed static test failure

45a9bec

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jan 27, 2023

m2-assistant bot mentioned this pull request Feb 23, 2023

[Issue] reference directive restored for _extends.less. extends replaced to mixins in _extend.less #36914

Closed

5 tasks

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: accept Progress: ready for testing labels Feb 23, 2023

magento-devops-reposync-svc merged commit f6e0bc3 into magento:2.4-develop Mar 2, 2023

reference directive restored for _extends.less. extends replaced to mixins in _extend.less #35101

reference directive restored for _extends.less. extends replaced to mixins in _extend.less #35101

Uh oh!

Conversation

serhii-chernenko commented Feb 14, 2022 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Manual testing scenarios (*)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Feb 14, 2022

Uh oh!

ihor-sviziev commented Feb 14, 2022

Uh oh!

magento-automated-testing bot commented Feb 14, 2022

Uh oh!

ihor-sviziev commented Feb 14, 2022

Uh oh!

mrtuvn commented Feb 20, 2022

Uh oh!

mrtuvn commented Feb 20, 2022

Uh oh!

magento-automated-testing bot commented Mar 9, 2022

Uh oh!

mrtuvn commented Mar 9, 2022

Uh oh!

magento-automated-testing bot commented Mar 9, 2022

Uh oh!

mrtuvn commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrtuvn commented Jun 5, 2022

Uh oh!

mrtuvn commented Jun 5, 2022

Uh oh!

magento-automated-testing bot commented Jun 5, 2022

Uh oh!

magento-automated-testing bot commented Jun 5, 2022

Uh oh!

mrtuvn commented Jun 6, 2022

Uh oh!

mrtuvn left a comment

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Jan 5, 2023

Uh oh!

engcom-Echo commented Jan 17, 2023

Uh oh!

magento-automated-testing bot commented Jan 17, 2023

Uh oh!

engcom-Echo commented Jan 20, 2023

Uh oh!

engcom-Echo commented Jan 24, 2023

Uh oh!

magento-automated-testing bot commented Jan 24, 2023

Uh oh!

engcom-Echo commented Jan 25, 2023

Uh oh!

magento-automated-testing bot commented Jan 25, 2023

Uh oh!

engcom-Echo commented Jan 25, 2023

Uh oh!

magento-automated-testing bot commented Jan 25, 2023

Uh oh!

engcom-Echo commented Jan 27, 2023

Uh oh!

engcom-Lima commented Feb 23, 2023

Uh oh!

Uh oh!

serhii-chernenko commented Feb 14, 2022 •

edited by m2-assistant bot

Loading

mrtuvn commented Mar 9, 2022 •

edited

Loading