Skip to content

fix(urlrewrite,graphql): routes now handles disabled entities #36968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Mar 6, 2023

Description (*)

Related Pull Requests

b420851#diff-b7c9feb0413b4e410ae1e7faf50efc9a56df002c818b580df07745fcb188b7c3

Fixed Issues (if relevant)

Fixes: #36268

Manual testing scenarios (*)

See #36268

Questions or comments

I've written this as a patch against v2.4.4-p2, not against 2.4-develop. I'm not interested in fixing this for v2.4.5/2.4.6/2.4-develop until I use them. If you want to close this PR and make it work with develop, feel free. I don't care.

I'm also not interested in writing tests for this.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 6, 2023

Hi @damienwebdev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Mar 6, 2023
@drpayyne
Copy link
Contributor

drpayyne commented Feb 7, 2024

Hi @damienwebdev, how are you doing? :) Do you have any idea why this PR was closed? Was it implemented elsewhere or what?

hi @andrewbess, maybe this is something you clarify please? thanks and much appreciated.

@magento-devops-reposync-svc @oneserv-heuser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphQL] route query ignoring whether a product/category is disabled
3 participants