Skip to content

Fixed issue .ui-state-focus missing from main navigation in 2.4.5 and 2.4.6 #37571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed issue .ui-state-focus missing from main navigation in 2.4.5 and 2.4.6 #37571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65fc2ca
changed style selector for focused menu item to "ui-state-active"
rostilos Jun 2, 2023
9b25f81
Merge branch '2.4-develop' into fix-for-issue-37300
engcom-Hotel Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/web/css/source/lib/_navigation.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@

&.active {
.all-category {
.ui-state-focus {
.ui-state-active {
Copy link
Contributor

@engcom-Hotel engcom-Hotel Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the class name in backward-compatible way like the below:

.ui-state-active, .ui-state-focus

.lib-css(background, @_nav-level0-item-background-color-active);
.lib-css(border-color, @_nav-level0-item__active__border-color);
.lib-css(border-style, @_nav-level0-item__active__border-style);
Expand Down Expand Up @@ -354,7 +354,7 @@
position: relative;
display: inline-block;

&:hover, &.ui-state-focus {
&:hover, &.ui-state-active {
.lib-css(background, @_nav-level0-item-background-color-hover);
.lib-css(border, @_nav-level0-item-border-hover);
.lib-css(color, @_nav-level0-item-color-hover);
Expand Down Expand Up @@ -441,7 +441,7 @@
.lib-css(text-decoration, @_submenu-item-text-decoration);

&:hover,
&.ui-state-focus {
&.ui-state-active {
.lib-css(background, @_submenu-item__hover__background-color);
.lib-css(border, @_submenu-item-border-hover);
.lib-css(color, @_submenu-item-color-hover);
Expand Down