Skip to content

38325 make city field optional in address #38470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

38325 make city field optional in address #38470

wants to merge 5 commits into from

Conversation

SilinMykola
Copy link
Contributor

Description (*)

In this PR added the field to the configuration to make the field 'City' not required in the forms. Also changed the shipping address form, and customer register form, and added the MFTF test for the field in configuration.

Related Pull Requests

There is no related PR

Fixed Issues (if relevant)

  1. Fixes Cannot make city field optional in addresses #38325

Manual testing scenarios (*)

  1. Change the configuration for the City field in Configuration -> Customers -> Name and Address Options -> Show City
  2. Check on the frontend on the checkout shipping address step, customer address edit form.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 25, 2024

Hi @SilinMykola. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Feb 25, 2024
@SilinMykola
Copy link
Contributor Author

@magento run all tests

@andrewbess andrewbess self-assigned this Feb 25, 2024
@SilinMykola
Copy link
Contributor Author

@magento run all tests

@SilinMykola SilinMykola force-pushed the 38325_make_city_not_required branch from 753b794 to 1b651ad Compare March 3, 2024 18:42
@SilinMykola
Copy link
Contributor Author

@magento run all tests

@SilinMykola SilinMykola force-pushed the 38325_make_city_not_required branch from 1b651ad to 7f07cf3 Compare March 18, 2024 07:50
@SilinMykola
Copy link
Contributor Author

@magento run all tests

1 similar comment
@SilinMykola
Copy link
Contributor Author

@magento run all tests

@SilinMykola SilinMykola force-pushed the 38325_make_city_not_required branch from dca7ce7 to 2c4630f Compare December 16, 2024 15:52
@SilinMykola
Copy link
Contributor Author

@magento run all rests

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@SilinMykola
Copy link
Contributor Author

@magento run all rests

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@SilinMykola
Copy link
Contributor Author

@magento run all tests

@SilinMykola
Copy link
Contributor Author

@magento run all tests

@SilinMykola SilinMykola mentioned this pull request Mar 23, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewbess andrewbess

Labels
Component: Customer Priority: P3 May be fixed according to the position in the backlog. Progress: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot make city field optional in addresses
3 participants
@SilinMykola @mrtuvn @andrewbess