Bug/ac 12310 product image hide csv import #39034

Mohamed-Asar · 2024-08-10T11:32:19Z

…pdate through csv importer issue fix

Description (*)

hide_from_product_page not updating in product update through csv importer

Fixed Issues (if relevant)

Fixes hide_from_product_page not updating in product update through csv importer #38882

Manual testing scenarios (*)

Add hide_from_product_page column for any of the product image in csv file, after the import, open the product in admin and see if the image is hidden or not
Remove any of the image from hide_from_product_page column and see if the hide_from_product_page attribute is removed

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…pdate through csv importer issue fix

…on the csv sheet

m2-assistant · 2024-08-10T11:32:23Z

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Mohamed-Asar · 2024-08-10T11:33:18Z

@magento run all tests

…mport

engcom-Hotel · 2024-11-28T06:54:43Z

@magento run all tests

engcom-Hotel

Hello @Mohamed-Asar,

Thanks for the contribution!

Please review the failed automated tests, such as static and integration tests. They are failing due to PR changes.

Thanks

Mohamed-Asar · 2024-11-28T11:47:11Z

@engcom-Hotel Sure, I will check and fix it

…into bug/AC-12310-product-image-hide-csv-import

…github.com/Mohamed-Asar/magento2 into bug/AC-12310-product-image-hide-csv-import

Mohamed-Asar · 2024-11-28T17:00:13Z

@magento run all tests

Mohamed-Asar · 2024-11-29T06:35:26Z

@engcom-Hotel Please review the test results now, All the issues are fixed, i see only one warning which is copyright is missing, do i need to update the copyright like below ?

/************************************************************************
 *
 * Copyright 2024 Adobe
 * All Rights Reserved.
 *
 * NOTICE: All information contained herein is, and remains
 * the property of Adobe and its suppliers, if any. The intellectual
 * and technical concepts contained herein are proprietary to Adobe
 * and its suppliers and are protected by all applicable intellectual
 * property laws, including trade secret and copyright laws.
 * Dissemination of this information or reproduction of this material
 * is strictly forbidden unless prior written permission is obtained
 * from Adobe.
 * ************************************************************************
 */

engcom-Hotel · 2024-11-29T08:26:40Z

Hello @Mohamed-Asar,

You just need to update the copyright information as below:

/**
 * Copyright 2011 Adobe
 * All Rights Reserved.
**/

Mohamed-Asar · 2024-11-29T10:50:30Z

@magento run all tests

Mohamed-Asar · 2024-12-07T14:15:06Z

@engcom-Hotel Changes done. please review

…mport

engcom-Bravo · 2024-12-10T04:47:00Z

@magento run all tests

engcom-Bravo · 2024-12-10T10:30:55Z

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Add hide_from_product_page column for any of the product image in csv file, after the import, open the product in admin and see if the image is hidden or not
Remove any of the image from hide_from_product_page column and see if the hide_from_product_page attribute is removed

Before: ✖️

We are unable to make the image visible again.

After: ✔️

We are able to make the image visible(unhide) successfully.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

…mport

engcom-Dash · 2024-12-13T08:06:40Z

@magento run all tests

engcom-Dash · 2024-12-13T12:03:17Z

Raised internal approval Jira for the SVC failure. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.

Mohamed-Asar · 2025-01-30T06:52:22Z

@engcom-Dash Any updates from the internal team ?

engcom-Charlie · 2025-02-03T11:46:03Z

Hi @Mohamed-Asar,

We are following up with our approval JIRA and will let you know once will get all required approvals. For now, can you please have a look into the conflicts.

Thank you!

…github.com/Mohamed-Asar/magento2 into bug/AC-12310-product-image-hide-csv-import

Mohamed-Asar · 2025-02-04T03:52:47Z

@engcom-Charlie I fixed the conflict, please check

Mohamed-Asar · 2025-02-04T04:06:13Z

@magento run all tests

Mohamed-Asar · 2025-03-25T15:46:23Z

Hi @Mohamed-Asar,

We are following up with our approval JIRA and will let you know once will get all required approvals. For now, can you please have a look into the conflicts.

Thank you!

@engcom-Charlie did you hear back from the internal team, any update on this ?

engcom-Charlie · 2025-03-26T04:31:13Z

Hi @Mohamed-Asar,
We are following up with our approval JIRA and will let you know once will get all required approvals. For now, can you please have a look into the conflicts.
Thank you!

@engcom-Charlie did you hear back from the internal team, any update on this ?

Hi @Mohamed-Asar,

We will let you know once we will get all required approvals on the JIRA. Thank you for your patience.

Mohamed-Asar · 2025-05-23T10:41:03Z

@engcom-Charlie Any update on this ? its been pending for a while

engcom-Charlie · 2025-05-29T09:46:41Z

Hi @Mohamed-Asar,

Thank you for your patience.

As I have mentioned, we are following up on the approval JIRA. We will let you know once will get all required approvals.

Mohamed-Asar added 2 commits August 10, 2024 16:23

AC-12310 Issue#38882 hide_from_product_page not updating in product u…

108c382

…pdate through csv importer issue fix

AC-12310 Issue#38882 update image visiblity only if the column exist …

1718946

…on the csv sheet

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 10, 2024

m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Aug 10, 2024

m2-community-project bot added the Progress: pending review label Aug 10, 2024

Mohamed-Asar and others added 2 commits August 10, 2024 19:13

AC-12310 Issue#38882 code refactor

1609f75

Merge branch '2.4-develop' into bug/AC-12310-product-image-hide-csv-i…

9d6f20f

…mport

engcom-Hotel self-requested a review November 28, 2024 10:39

engcom-Hotel requested changes Nov 28, 2024

View reviewed changes

m2-community-project bot assigned engcom-Hotel Nov 28, 2024

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Nov 28, 2024

Mohamed-Asar added 3 commits November 28, 2024 17:33

Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento2 …

d143e17

…into bug/AC-12310-product-image-hide-csv-import

Integration and static tests fixed

08e4d4d

Merge branch 'bug/AC-12310-product-image-hide-csv-import' of https://…

a8902b5

…github.com/Mohamed-Asar/magento2 into bug/AC-12310-product-image-hide-csv-import

copyright changes

c1a5065

engcom-Hotel approved these changes Dec 9, 2024

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Dec 9, 2024

Merge branch '2.4-develop' into bug/AC-12310-product-image-hide-csv-i…

d74149a

…mport

engcom-Charlie self-assigned this Dec 10, 2024

Priyakshic added the Project: Community Picked PRs upvoted by the community label Dec 11, 2024

engcom-Charlie removed their assignment Dec 13, 2024

engcom-Dash self-assigned this Dec 13, 2024

Merge branch '2.4-develop' into bug/AC-12310-product-image-hide-csv-i…

0d666ea

…mport

engcom-Charlie self-assigned this Feb 3, 2025

Mohamed-Asar added 2 commits February 4, 2025 09:17

Conflicts fixed

2f79a4f

Merge branch 'bug/AC-12310-product-image-hide-csv-import' of https://…

9df91fc

…github.com/Mohamed-Asar/magento2 into bug/AC-12310-product-image-hide-csv-import

Bug/ac 12310 product image hide csv import #39034

Are you sure you want to change the base?

Bug/ac 12310 product image hide csv import #39034

Conversation

Mohamed-Asar commented Aug 10, 2024 • edited by ihor-sviziev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 10, 2024

Uh oh!

Mohamed-Asar commented Aug 10, 2024

Uh oh!

engcom-Hotel commented Nov 28, 2024

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Mohamed-Asar commented Nov 28, 2024

Uh oh!

Mohamed-Asar commented Nov 28, 2024

Uh oh!

Mohamed-Asar commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Hotel commented Nov 29, 2024

Uh oh!

Mohamed-Asar commented Nov 29, 2024

Uh oh!

Mohamed-Asar commented Dec 7, 2024

Uh oh!

engcom-Bravo commented Dec 10, 2024

Uh oh!

engcom-Bravo commented Dec 10, 2024

✔️ QA Passed

Uh oh!

engcom-Dash commented Dec 13, 2024

Uh oh!

engcom-Dash commented Dec 13, 2024

Uh oh!

Mohamed-Asar commented Jan 30, 2025

Uh oh!

engcom-Charlie commented Feb 3, 2025

Uh oh!

Mohamed-Asar commented Feb 4, 2025

Uh oh!

Mohamed-Asar commented Feb 4, 2025

Uh oh!

Mohamed-Asar commented Mar 25, 2025

Uh oh!

engcom-Charlie commented Mar 26, 2025

Uh oh!

Mohamed-Asar commented May 23, 2025

Uh oh!

engcom-Charlie commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mohamed-Asar commented Aug 10, 2024 •

edited by ihor-sviziev

Loading

Mohamed-Asar commented Nov 29, 2024 •

edited

Loading

engcom-Charlie commented May 29, 2025 •

edited

Loading