Skip to content

39056: Product stock status change does not purge product varnish cache #39118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

39056: Product stock status change does not purge product varnish cache #39118

wants to merge 2 commits into from

Conversation

zakdma
Copy link
Contributor

@zakdma zakdma commented Aug 27, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 27, 2024

Hi @zakdma. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@zakdma
Copy link
Contributor Author

zakdma commented Aug 28, 2024

@magento run all tests

@engcom-Hotel engcom-Hotel linked an issue Aug 28, 2024 that may be closed by this pull request
Product stock status change does not purge product varnish cache #39056
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 28, 2024
@zakdma
Copy link
Contributor Author

zakdma commented Aug 28, 2024

@magento run Static Tests
@magento run WebAPI Tests
@magento run WebAPI Tests
@magento run Integration Tests

kandy
kandy reviewed Aug 29, 2024
View reviewed changes
app/code/Magento/CatalogInventory/Model/Indexer/Stock.php
@@ -54,6 +54,7 @@ public function __construct(
public function execute($ids)
{
$this->_productStockIndexerRows->execute($ids);
$this->getCacheContext()->registerEntities(ProductModel::CACHE_TAG, $ids);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is cleanup all caches in case on changes to a inventory, not only in. case of inventory status.
As result product page/category page cache will be cleanup after any checkout and significanly reduce cache hit/miss

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the main idea. We need to update product page in case ANY inventory change for product, not only status but also quantity.
ERP updates inventory using API and we need product pages updated accordingly.
Maybe its not suitable for Magento platform itself, in this case just close this.

@zakdma
Copy link
Contributor Author

zakdma commented Aug 30, 2024

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandy kandy kandy left review comments

Assignees

@kandy kandy

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product stock status change does not purge product varnish cache
3 participants
@zakdma @kandy @engcom-Hotel