Skip to content

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: 2.4-develop
Choose a base branch
from
Open
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
9111182
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Mar 1, 2025
364b4e5
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Mar 1, 2025
2a9dec5
Merge branch '2.4-develop' into fix-for-issue-39169
engcom-Hotel Mar 28, 2025
131815c
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 2, 2025
0d8b6b0
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 10, 2025
c8c8b35
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 10, 2025
e79e0fa
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 14, 2025
0e95cd4
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 14, 2025
1ce9b74
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 14, 2025
a3fe48c
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 15, 2025
7f6699e
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 16, 2025
3a45985
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 21, 2025
b42fab8
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 22, 2025
8ace126
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 28, 2025
58b3d98
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 28, 2025
5cbfdb6
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 28, 2025
cf359ba
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Apr 28, 2025
2cea5b6
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 2, 2025
ed831bd
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 2, 2025
93c0caa
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 3, 2025
331dc74
magento/magento2#39146: Image resize queue error due to .tmp file han…
KrasnoshchokBohdan May 12, 2025
9b27e4d
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 12, 2025
fe976d7
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 17, 2025
188ece2
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 17, 2025
0a5d7f1
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 19, 2025
157c99a
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 19, 2025
706ee4c
Merge branch '2.4-develop' into fix-for-issue-39169
engcom-Hotel May 21, 2025
db809f1
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 22, 2025
cff0ee8
Merge branch '2.4-develop' into fix-for-issue-39169
engcom-Hotel May 28, 2025
18260e7
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 29, 2025
015fd43
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan May 30, 2025
8442ee0
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan May 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
$scopeTimeStamp = $this->scopeTimeStamp($scope);
$fromTimeStamp = strtotime($dateFrom);
$toTimeStamp = strtotime($dateTo);
if ($dateTo) {
if ($dateTo && date('H:i:s', strtotime($dateTo)) === '00:00:00') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have the same +1 day result if use '00:00:00' in the API query. I'm not sure that it's correct solution

// fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
$toTimeStamp += 86400;
}
Expand Down