improve error handling SchemaBuilder #39799

Genaker · 2025-04-10T00:53:16Z

Extending error context :
Previousle:
Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91

Few Moments later:
Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91 Error processing table catalog_eav_attribute column is_used_in_autocomplete

Help undersend the issue without heavy debugging!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] improve error handling SchemaBuilder #39816: improve error handling SchemaBuilder

Extending error context : Previous: ```Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91``` Now: ```Warning: Undefined array key "type" in /var/www/html/magento/vendor/magento/framework/Setup/Declaration/Schema/Db/SchemaBuilder.php on line 91 Error processing table catalog_eav_attribute column is_used_in_autocomplete``` Help undersend the issue without heavy debugging!

m2-assistant · 2025-04-10T00:53:21Z

Hi @Genaker. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

orkuncv · 2025-04-15T08:13:25Z

For tables that are defined without columns and marked with disabled="true", like the example below:
<table name="amasty_stockstatus_quantityranges" resource="default" engine="innodb" comment="amasty_stockstatus_quantityranges" disabled="true"/>

You could consider adding the following check in your processing logic, e.g., around line 89:
if (!isset($tableColumns['column'])) { error_log("Missing 'column' key for table '{$keyTable}': " . json_encode($tableColumns)); continue; }

Genaker · 2025-04-15T08:16:35Z

For tables that are defined without columns and marked with disabled="true", like the example below:

<table name="amasty_stockstatus_quantityranges" resource="default" engine="innodb" comment="amasty_stockstatus_quantityranges" disabled="true"/>

You could consider adding the following check in your processing logic, e.g., around line 89:

`if (!isset($tableColumns['column'])) {
error_log("Missing 'column' key for table '{$keyTable}': " . json_encode($tableColumns));

continue;
}`

is it for me? Who should add?

engcom-Hotel · 2025-04-15T11:25:07Z

@magento create issue

engcom-Hotel · 2025-05-16T05:34:09Z

@magento run all tests

engcom-Hotel

Hello @Genaker,

Thanks for the contribution!

Please refer to the below review points & fix the failed static tests. Other failures seems flaky to me.

Thanks

engcom-Hotel · 2025-05-19T05:49:11Z

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/SchemaBuilder.php

+
+                        // Throw a new exception with the extended message
+                        // This preserves the original error but adds our context
+                        throw new \Exception($errorMessage, $e->getCode(), $e);


With throwing the error also ensure that the new error message is properly surfaced in logs.

engcom-Hotel · 2025-05-19T05:55:03Z

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/SchemaBuilder.php

+                            "%s\nError processing table %s column %s",
+                            $e->getMessage(),
+                            $keyTable,
+                            $keyColumn


As per this comment #39799 (comment), please add a check with table is defined without columns.

Hello @engcom-Hotel , the check is already there at line 101

engcom-Hotel · 2025-05-19T06:01:04Z

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/SchemaBuilder.php

+
+                        // Throw a new exception with the extended message
+                        // This preserves the original error but adds our context
+                        throw new \Exception($errorMessage, $e->getCode(), $e);


Instead of rethrowing a generic \Exception, consider a specific exception type, e.g., \Magento\Framework\Exception\LocalizedException

unfortunately i can't do this now. However feel free edit this PR.

…tch-3

engcom-Dash · 2025-05-22T11:39:11Z

@magento run all tests

engcom-Dash · 2025-05-22T14:21:04Z

@magento run all tests

engcom-Dash · 2025-05-23T05:22:34Z

Hello @engcom-Hotel I have fixed the review comments, static & unit test failures. Could you please review it ?

engcom-Hotel · 2025-05-23T07:34:04Z

@magento run Database Compare, Integration Tests, WebAPI Tests

engcom-Hotel

Hello @Genaker,

Please sign the CLA, meanwhile we are moving this PR On Hold.

Thanks

hostep mentioned this pull request Apr 10, 2025

Undefined array key "type" Db/SchemaBuilder.php on line 93 #39801

Open

5 tasks

m2-assistant bot mentioned this pull request Apr 15, 2025

[Issue] improve error handling SchemaBuilder #39816

Open

5 tasks

engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Apr 15, 2025

ct-prd-projects-boards-automation bot added this to Pull Requests Dashboard Apr 15, 2025

github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 15, 2025

ct-prd-projects-boards-automation bot added the Progress: pending review label Apr 15, 2025

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label May 13, 2025

ct-prd-projects-boards-automation bot added this to Community Dashboard May 13, 2025

ct-prd-projects-boards-automation bot moved this to Pending Review in Community Dashboard May 13, 2025

ct-prd-projects-boards-automation bot removed this from Pull Requests Dashboard May 13, 2025

engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 14, 2025

Merge branch '2.4-develop' into patch-3

85e70c1

engcom-Hotel requested changes May 19, 2025

View reviewed changes

engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard May 19, 2025

ct-prd-projects-boards-automation bot added the Progress: needs update label May 19, 2025

engcom-Dash self-assigned this May 21, 2025

engcom-Dash and others added 3 commits May 22, 2025 16:57

Merge branch '2.4-develop' into patch-3

205ca1b

Fixed Review Comments & static failures

f35b258

Merge branch 'patch-3' of https://github.com/Genaker/magento2 into pa…

86966f7

…tch-3

Fixed Unit Tests

393e74a

engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard May 23, 2025

ct-prd-projects-boards-automation bot added Progress: review and removed Progress: needs update Progress: pending review labels May 23, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard May 23, 2025

engcom-Hotel requested changes May 23, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard May 23, 2025

engcom-Hotel moved this from Ready for Testing to On Hold in Community Dashboard May 23, 2025

ct-prd-projects-boards-automation bot added Progress: ready for testing Progress: on hold and removed Progress: review labels May 23, 2025

improve error handling SchemaBuilder #39799

Are you sure you want to change the base?

improve error handling SchemaBuilder #39799

Uh oh!

Conversation

Genaker commented Apr 10, 2025 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 10, 2025

Uh oh!

orkuncv commented Apr 15, 2025

Uh oh!

Genaker commented Apr 15, 2025

Uh oh!

engcom-Hotel commented Apr 15, 2025

Uh oh!

engcom-Hotel commented May 16, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel May 19, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel May 19, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Dash May 22, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Genaker May 20, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Dash commented May 22, 2025

Uh oh!

engcom-Dash commented May 22, 2025

Uh oh!

engcom-Dash commented May 23, 2025

Uh oh!

engcom-Hotel commented May 23, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Genaker commented Apr 10, 2025 •

edited by m2-assistant bot

Loading