Skip to content

Added correction for og:type content value #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added correction for og:type content value #4827

wants to merge 2 commits into from

Conversation

atishgoswami
Copy link
Contributor

Added correction to the og:type meta tag content value.

Before:
<meta property="og:type" content="og:product" />

After:
<meta property="og:type" content="product" />

References:
Facebook Open Graph
Pinterest

@vkublytskyi
Copy link

@atishgoswami, Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below.

@vkublytskyi vkublytskyi added the MX label Jun 2, 2016
@atishgoswami
Copy link
Contributor Author

@vkublytskyi This "licence/cla" is not working, tried it a hundred times, still shows "not signed yet"

@hostep
Copy link
Contributor

hostep commented Jul 5, 2016

@atishgoswami: your commit was made with the user @atish-perficient
You should sign the CLA while logged in into github with that user I believe.

@atishgoswami
Copy link
Contributor Author

atishgoswami commented Jul 12, 2016

@hostep Nope still doesn't work

@atishgoswami
Copy link
Contributor Author

I am closing this pull request seems that the licence/cla is never going to work for me

@atishgoswami atishgoswami deleted the og-tag-correction branch July 13, 2016 19:45
magento-engcom-team pushed a commit that referenced this pull request Sep 27, 2019
[honey] MC-20255: Category Breadcrumbs are missing url_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants