Skip to content

fix placeholder for private blocks #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

m1klos
Copy link

@m1klos m1klos commented Jun 17, 2016

Fix for #5083

@melnikovi
Copy link
Member

Internal ticket created MAGETWO-54528

@adragus-inviqa
Copy link
Contributor

adragus-inviqa commented Jul 8, 2016

Shouldn't the 2nd arg of sprintf - $output - be removed, too?

Also, since now the actual wrap is not needed, it can have a simpler syntax, something like <!-- BLOCK <name> -->, so that the parser back in page-cache.js can have a more simpler/efficient search-and-replace algorithm.

@okorshenko
Copy link
Contributor

Hi @m1klos. Thank you for your Pull Request. This fix is for deprecated functionality. Please see official documentation Closing this PR.

Thank you @orlangur for linking these issues.

@okorshenko okorshenko closed this Jun 20, 2017
magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2019
[tango] MAGETWO-99311: Asynchronous image resizing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants