Skip to content

Add possibility generate varnish 4 config file, issue #864 #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add possibility generate varnish 4 config file, issue #864 #895

wants to merge 4 commits into from

Conversation

hummer2k
Copy link

@hummer2k hummer2k commented Jan 3, 2015

  • Added varnish 4 compatible vcl
  • Added possibility to extend config node system/full_page_cache/varnish/path to add new varnish versions.

Issue: #864

@ihor-sviziev
Copy link
Contributor

Looks like we have some issues with test Magento\Framework\Data\Form\Element\DateTest::testGetValue (or maybe implementation) when we have 1st month of year.

@vpelipenko vpelipenko added the PS label Jan 15, 2015
@otoolec
Copy link
Contributor

otoolec commented Feb 3, 2015

Thanks for submitting this PR. I've linked it to the internal ticket MAGETWO-32339 for issue #864

@otoolec otoolec added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 3, 2015
@vpelipenko
Copy link
Contributor

@hummer2k, unfortunately we can't accept this PR, due to duplication of our work. Last few weeks we also worked on Varnish 4 compatibility for page cache. This work was announced in #864 issue. Our improvement is already finished by development team and will be available on public after next update at the end of this week. Please, stay tuned.

@hummer2k hummer2k closed this Feb 6, 2015
magento-team pushed a commit that referenced this pull request Mar 8, 2017
@ishakhsuvarov
Merge pull request #895 from magento-engcom/develop-prs-isolated
dc47c06 
[EngCom] Merge Community Pull Requests:
 - #8776
 - #8772
 - #8762
 - #8768
 - #8758
 - #8759
 - #8623
 - #8695
 - #8723
 - #8678
 - #8711
 - #8706
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this pull request Apr 29, 2018
Merge pull request magento#895 from magento-engcom/MSI-788-Synchroniz…
745b8f8 
…ation-With-Core

MSI-788: Synchronization with core.
magento-engcom-team added a commit that referenced this pull request Sep 10, 2019
@magento-engcom-team
ENGCOM-5795: Add resolver to determine if quote is virtual #895
66960b1 
 - Merge Pull Request magento/graphql-ce#895 from fooman/graphql-ce:virtual-quote
 - Merged commits:
   1. d54281a
magento-engcom-team pushed a commit that referenced this pull request Sep 10, 2019
@lenaorobei
ENGCOM-5795: Add resolver to determine if quote is virtual #895
2457268
diazwatson pushed a commit to diazwatson/magento2 that referenced this pull request Jan 16, 2020
magento#895 Fix for Media Gallery buttons are shifted to the left
4192ff3
diazwatson pushed a commit to diazwatson/magento2 that referenced this pull request Jan 17, 2020
magento#895 Fix for Media Gallery buttons are shifted to the left
a1959f6
magento-engcom-team added a commit that referenced this pull request Feb 9, 2020
@magento-engcom-team
ENGCOM-6664: #895 Fix for Media Gallery buttons are shifted to the left
16edcd3 
#26413

 - Merge Pull Request #26413 from diazwatson/magento2:feature/895_AdobeStockMediaGalleryShiftedToTheRight
 - Merged commits:
   1. 4192ff3
   2. 33f1535
   3. a1959f6
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6664: #895 Fix for Media Gallery buttons are shifted to the left
5c1e4f2 
#26413
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
🔃 [Magento Community Engineering] Community Contributions - 2.4-devel…
15b5c60 
…op expedited

Accepted Community Pull Requests:
 - #26413: #895 Fix for Media Gallery buttons are shifted to the left (by @diazwatson)
 - #26162: Fixed Issue with tier price 0 when saving product second time (by @ravi-chandra3197)
 - #26420: #8691: improved language pack inheritance order (by @sergiy-v)


Fixed GitHub Issues:
 - #25195: Issue with tier price 0 when saving product second time (reported by @keyurshah070) has been fixed in #26162 by @ravi-chandra3197 in 2.4-develop branch
   Related commits:
     1. ffab78e
     2. ee152fc
     3. 918fd02
     4. f309ae0

 - #8691: Language pack inheritance order is incorrect (reported by @koenner01) has been fixed in #26420 by @sergiy-v in 2.4-develop branch
   Related commits:
     1. 8ce0822
     2. 51ddad3
     3. 0237c02
     4. c42ebc1
magento-cicd2 pushed a commit that referenced this pull request Apr 28, 2020
@sivaschenko
#895 Fix for Media Gallery buttons are shifted to the left
ef50367
magento-cicd2 pushed a commit that referenced this pull request Apr 28, 2020
@sivaschenko
#895 Fix for Media Gallery buttons are shifted to the left
5ba830c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hummer2k @ihor-sviziev @otoolec @vpelipenko